Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: offline verified ddo deals #417

Merged
merged 10 commits into from
Feb 21, 2025
Merged

feat: offline verified ddo deals #417

merged 10 commits into from
Feb 21, 2025

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Feb 14, 2025

  • A new command to add DDO deals to table and pipeline

  • A new column in market_mk12_deal_pipeline to identify the DDO deal

  • Small changes in mk12 pipeline to accomodate DDO deals

  • UI changes for DDO

  • Some small fixes to deal pipeline

  • Test without commP

  • Test with commP

  • Test with URL

  • Test with PieceLocator

  • Verify indexing

  • verify Announcing

  • Verify no announce is respected

  • Verify if !should_index then deal is not announced

  • Create a quick DDO deal script

  • Verify f05 deal flow is working

Piece Info showing DDO deal

Screenshot 2025-02-21 at 12 39 54 PM

DDO deals in deal list page

Screenshot 2025-02-21 at 12 40 01 PM

Deal pipeline showing DDO deal

Screenshot 2025-02-21 at 12 40 12 PM

F05 Deals with DDO

Screenshot 2025-02-21 at 4 55 06 PM

Completed F05 deals

Screenshot 2025-02-21 at 5 30 01 PM

Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments/questions.

Can we test that non-ddo deals still work with the changes here?

@LexLuthr LexLuthr merged commit dd374a2 into main Feb 21, 2025
31 checks passed
@LexLuthr LexLuthr deleted the feat/ddo branch February 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants