-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: offline verified ddo deals #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Feb 21, 2025
magik6k
reviewed
Feb 21, 2025
magik6k
reviewed
Feb 21, 2025
magik6k
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments/questions.
Can we test that non-ddo deals still work with the changes here?
magik6k
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new command to add DDO deals to table and pipeline
A new column in market_mk12_deal_pipeline to identify the DDO deal
Small changes in mk12 pipeline to accomodate DDO deals
UI changes for DDO
Some small fixes to deal pipeline
Test without commP
Test with commP
Test with URL
Test with PieceLocator
Verify indexing
verify Announcing
Verify no announce is respected
Verify if !should_index then deal is not announced
Create a quick DDO deal script
Verify f05 deal flow is working
Piece Info showing DDO deal
DDO deals in deal list page
Deal pipeline showing DDO deal
F05 Deals with DDO
Completed F05 deals