Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved PSD selection and findURL in market #419

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: improved PSD selection and findURL in market #419

merged 2 commits into from
Feb 21, 2025

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Feb 17, 2025 •
edited
Loading

No description provided.

@LexLuthr LexLuthr requested a review from magik6k February 17, 2025 11:26
magik6k
magik6k reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem I see that needs addressing is that this can assign one task ID to deals from multiple SPs

Probably should create tasks in a loop, and in each task add we should only schedule PSD for up to one SP

@LexLuthr LexLuthr requested a review from magik6k February 19, 2025 13:10
@LexLuthr LexLuthr merged commit b98675c into main Feb 21, 2025
31 checks passed
@LexLuthr LexLuthr deleted the fix/psd-deals branch February 21, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k