Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update config comment with expected input and defaults #427

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Mar 3, 2025

This PR does the following:

  1. Dump custom Duration type for TOML as time.Duration is supported by TOML by default now.
  2. Removed unused configuration
  3. Fix commenting for sections
  4. Fix commenting for [Arrays]
  5. Small UI and doc fix
# Subsystems defines configuration settings for various subsystems within the Curio node.
#
# type: CurioSubsystemsConfig
[Subsystems]

  # EnableWindowPost enables window post to be executed on this curio instance. Each machine in the cluster
  # with WindowPoSt enabled will also participate in the window post scheduler. It is possible to have multiple
  # machines with WindowPoSt enabled which will provide redundancy, and in case of multiple partitions per deadline,
  # will allow for parallel processing of partitions.
# Market specifies configuration options for the Market subsystem within the Curio node.
#
# type: MarketConfig
[Market]

  # StorageMarketConfig houses all the deal related market configuration
  #
  # type: StorageMarketConfig
  [Market.StorageMarketConfig]

    # MK12 encompasses all configuration related to deal protocol mk1.2.0 and mk1.2.1 (i.e. Boost deals)
    #
    # type: MK12Config
    [Market.StorageMarketConfig.MK12]

# Addresses specifies the list of miner addresses and their related wallet addresses.
#
# type: []CurioAddresses
[[Addresses]]

  # PreCommitControl is an array of Addresses to send PreCommit messages from
  #
  # type: []string
  #PreCommitControl = []

  # CommitControl is an array of Addresses to send Commit messages from
  #
  # type: []string
  #CommitControl = []

  # DealPublishControl is an array of Address to send the deal collateral from with PublishStorageDeal Message
  #
  # type: []string
  #DealPublishControl = []

Screenshot 2025-03-03 at 2 50 55 PM Screenshot 2025-03-03 at 2 51 21 PM Screenshot 2025-03-03 at 2 51 29 PM

CID Gravity UI fix

False by default

Screenshot 2025-03-03 at 2 57 14 PM

True

Screenshot 2025-03-03 at 2 56 46 PM

@LexLuthr LexLuthr marked this pull request as draft March 3, 2025 15:00
@LexLuthr
Copy link
Contributor Author

LexLuthr commented Mar 3, 2025

When adding any kind of Fee

Screenshot 2025-03-03 at 8 51 55 PM

When adding any duration

Screenshot 2025-03-03 at 9 19 46 PM

@LexLuthr LexLuthr marked this pull request as ready for review March 3, 2025 17:28
@LexLuthr LexLuthr requested review from snadrus and magik6k March 3, 2025 17:28
@LexLuthr LexLuthr linked an issue Mar 4, 2025 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve invalid config value message
1 participant