no fee based aggregation/batching #492
Conversation
LexLuthr
force-pushed
the
fix/aggregation
branch
from
85a5a23 to
515448c
Compare
LexLuthr
force-pushed
the
fix/aggregation
branch
from
515448c to
d593aca
Compare
It is basically the same function but we don't check for fee anymore. |
deps/config/load.go
Outdated
There was a problem hiding this comment.
What do the changes here do?
There was a problem hiding this comment.
Oh! Those are mostly due to how comp library works. It treats "0h5m10s" different from "5h0m0s" for some reason.
The other change is because if we have 2 config parameters with same name then current load confuse the value because map we created was global. This change updates the map keys to be config section specific. To explain is simply:
The preCommit msg timeout of 1 hour (default 4 hour) will no longer be treated as default value due to commit msg timeout default being 1 hour.
| */ | ||
|
|
||
| FOR batch_rec IN | ||
| WITH locked AS ( |
There was a problem hiding this comment.
My understanding is that WITH locked AS does nothing at all in yugabyte
There was a problem hiding this comment.
I think you are confusing the table name with "FOR UPDATE;" at the end for actual locking. I can change the table name to avoid confusing.
fixes #489
Should not break nodes running older code during upgrade