Apply Dynamic cfg to p2 & p3 cases by snadrus · Pull Request #711 · filecoin-project/curio

snadrus · 2025-10-17T22:17:01Z

This builds atop PR #710 (which implemented P1 items) to implement P2 & P3 items of the following punchlist.
Logic fixes: forgot 'base' changes! Atomic where better.
New component: working with Dynamic[struct{...}] required a new approach.

Misc_Included_Commits
Better testing separation by guaranteeing different databases used.
SQL:

NEW: an AFTER trigger switched to BEFORE + modifying NEW so there's no window of time for error.
MOD: modified old code to help reapply work better. Should have no effect on fully-upgraded setups.

PunchList
The remaining items are P4-5 and "No need"

Subsystems

XXMax P4, medium difficulty

Fees - all P2, easy, done
Addresses - all P1, hard, done
Proving - all, P4, easy
Http - no need
Market

StorageMarketConfig
-- MK12 - all here, P3, easy-ish, done
-- MK2, P3, done
IPNI - P4
Indexing - P5, easy
PieceLocator - P2, easy, done

Ingest - P1, done
Seal - No need
APIs->Chain - P2, medium-hard, done
Alerting - P3, easy, done
Batching - P2, easy, done

todo: startup fails?

snadrus · 2025-11-10T16:55:56Z

I will add a test for the eth_client by moving money between wallets and back after a failover (how many lotus nodes, stop).

… into dyn-cfg-p23

Reiers · 2025-11-21T20:59:19Z

nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Failed with result 'exit-code'.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/main.go:206 +0x115d
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.main()
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/main.go:234 +0x45
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.runApp(0x47ea9a0?)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/v2@v2.27.7/app.go:307
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*App).Run(...)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/v2@v2.27.7/app.go:333 +0x5a5
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*App).RunContext(0xc0002d8a00, {0x5dd72b8, 0x9ef9c00}, {0xc00004e180, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/v2@v2.27.7/command.go:269 +0xa45
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*Command).Run(0xc0004491e0, 0xc00043f880, {0xc00004e180, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/go/pkg/mod/github.com/urfave/cli/v2@v2.27.7/command.go:276 +0x7be
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/urfave/cli/v2.(*Command).Run(0x9cd1000, 0xc00077a000, {0xc000638c30, 0x1, 0x1})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/cmd/curio/run.go:120 +0x3d8
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: main.init.func27(0xc00077a000)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/deps.go:252 +0x815
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.(*Deps).PopulateRemainingDeps(0xc000026120, {0x5dd7548, 0xc0005e25f0}, 0xc00077a000,  0x85?)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/apiinfo.go:120 +0x149
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.GetFullNodeAPIV1Curio(0xc00077a000, 0xc000c02de0)
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/apiinfo.go:117 +0xdc5
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps.GetFullNodeAPIV1Curio.func2()
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]:         /home/reiers/curio/deps/config/dynamic.go:68 +0x239
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: github.com/filecoin-project/curio/deps/config.(*Dynamic[...]).Set(0x5dfdd80, {0xc0007c1160, 0x2, 0x2})
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: goroutine 1 [running]:
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1ef5d39]
nov. 21 21:37:38 neuranodes-storage-provider curio[1693204]: panic: runtime error: invalid memory address or nil pointer dereference
nov. 21 21:37:38 
neuranodes-storage-provider curio[1693204]: repopath ~/.curio
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: Started Curio.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: Stopped Curio.
nov. 21 21:37:38 neuranodes-storage-provider systemd[1]: curio.service: Scheduled restart job, restart counter is at 5.
nov. 21 21:37:27 neuranodes-storage-provider systemd[1]: curio.service: Failed with result 'exit-code'.
nov. 21 21:37:27 neuranodes-storage-provider systemd[1]: curio.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Then reverting back to main:

snadrus · 2025-12-04T00:01:47Z

Reiers testing:
The failure happens right after, during the migration:
Upgrading 20251107-fix-ready-at-triggers.sql
ERROR: column "update_ready_at" does not exist (SQLSTATE 42703)

magik6k

Few minor things to address, looks really great!

cmd/curio/tasks/tasks.go

magik6k · 2025-12-08T11:26:31Z

deps/apiinfo.go

Definitely must do some manual testing on this

I have no idea how, so review itests/eth_test.go

magik6k · 2025-12-08T11:40:27Z

harmony/harmonydb/sql/20251107-fix-ready-at-triggers.sql

This just adds a 'on new insert' handling? Any issue this is fixing?

AI talked me into something that i should not have been. It thought some test failure was related to this AFTER trigger needing to be a BEFORE, then the test cleaned-up, but I think that line of thinking was garbage: file deleted

Makefile

snadrus added 30 commits September 26, 2025 12:52

dyncfg 90% done

e87c370

tests, docs, and clean-up

0662132

updates

260e345

checkers

0403006

allow cmp.Equal

d88a898

fixed dynamic

886dfd0

avoid unsettable

02772cc

Merge branch 'main' into dyn-cfg

de69e43

change-notification

3240f22

ingest-easy

e03333d

go mod tidy

bb71ceb

md

317fed1

address1

575f029

dbg basetext

cabb400

fix bad import

8f7a6ac

test logger

ff6ebdc

dbgFail: is it in baseTest

17f1050

found 1 blocker for test failure: base was not included right

aa24527

Merge branch 'dyn-cfg' into apply-dyn-cfg

65ae076

rm dbg

dcc4786

completed addresses

1808bc9

lint

3779387

move mineraddress onchange one level up

5d27fbc

no pq, fix unmarshal

2c0286e

complex equal

b9cb21c

Merge branch 'dyn-cfg' into apply-dyn-cfg

1e0a2e1

mod tidy & naming

deb9967

fix Fil cmp panic

6d721d8

Merge branch 'dyn-cfg' into apply-dyn-cfg

7282be5

transparent-decode

0127d96

snadrus added 3 commits November 5, 2025 22:54

light lints

155a7e4

lint, zerofix

b0d3ea1

atomic updated, sql tests better

de5c88b

snadrus marked this pull request as draft November 6, 2025 23:56

db triggers, change timeouts

41422bb

snadrus marked this pull request as ready for review November 7, 2025 22:52

snadrus requested a review from LexLuthr November 7, 2025 22:59

snadrus added 4 commits November 11, 2025 11:13

eth test

9704ce0

ethclient test

81f4d31

ethtest

3d5710c

simpler eth failover test

0a7736c

snadrus removed request for LexLuthr and magik6k November 19, 2025 17:23

snadrus added 3 commits November 21, 2025 09:41

Merge branch 'main' into dyn-cfg-p23

7f2e82e

Merge branch 'dyn-cfg-p23' of https://github.com/filecoin-project/curio…

ab2020a

… into dyn-cfg-p23

lint

8a8f59b

snadrus mentioned this pull request Nov 24, 2025

Mainlining of Fast Snap logic #804

Merged

snadrus added 2 commits November 26, 2025 16:54

test

6be91a6

stupid mistake

4f4dddc

magik6k reviewed Dec 8, 2025

View reviewed changes

snadrus added 7 commits December 10, 2025 17:38

review- missed dyn, better names

b097074

removed unnecessary sql file

f9d58b9

run this for the first time

73be37c

Merge branch 'main' into dyn-cfg-p23

07e8702

merge build fix

07e3596

fix test

cf7f238

Merge branch 'main' into dyn-cfg-p23

dccbf0d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Apply Dynamic cfg to p2 & p3 cases#711

Apply Dynamic cfg to p2 & p3 cases#711
snadrus wants to merge 86 commits intomainfrom
dyn-cfg-p23

snadrus commented Oct 17, 2025 •

edited

Loading

Uh oh!

snadrus commented Nov 10, 2025

Uh oh!

Reiers commented Nov 21, 2025

Uh oh!

snadrus commented Dec 4, 2025

Uh oh!

magik6k left a comment

Uh oh!

Uh oh!

magik6k Dec 8, 2025

Uh oh!

snadrus Dec 10, 2025

Uh oh!

magik6k Dec 8, 2025

Uh oh!

snadrus Dec 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

snadrus commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snadrus commented Nov 10, 2025

Uh oh!

Reiers commented Nov 21, 2025

Uh oh!

snadrus commented Dec 4, 2025

Uh oh!

magik6k left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

magik6k Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

magik6k Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

snadrus commented Oct 17, 2025 •

edited

Loading

snadrus Dec 10, 2025 •

edited

Loading