fix: remove secrets, PII, response bodies from prod logs; preserve stack traces.#226
Open
joemocode-business wants to merge 3 commits intomainfrom
Open
fix: remove secrets, PII, response bodies from prod logs; preserve stack traces.#226joemocode-business wants to merge 3 commits intomainfrom
joemocode-business wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found secrets, PII, and external API response bodies reachable via console.error/console.warn in production in certain cases. This commit removes these. I also improved some of the errors that lacked stack traces, usually when we catch and return rather than relying on the catch-all error handler. This audit relies on properly setting WARN + here: #224
Secrets removed:
PII removed:
Stack traces preserved
Log level corrections: