fix(deps): pin supraseal-c2/sppark to pre-regression versions - #578
Conversation
sppark 0.1.12+ leaks GPU memory under FFI_USE_CUDA_SUPRASEAL=1, OOMing long-lived lotus-miner/lotus-worker processes. Hold supraseal-c2 at 0.1.1 and sppark at 0.1.11 until upstream ships a fix. Ref: filecoin-project/lotus#13634, supranational/sppark#81
There was a problem hiding this comment.
Pull request overview
Pins the CUDA SupraSeal dependency chain to known-good versions to avoid a reported GPU memory leak in sppark when building/running with FFI_USE_CUDA_SUPRASEAL=1, protecting long-lived Lotus miner/worker processes from OOM.
Changes:
- Add explicit version pins for
supraseal-c2(=0.1.1) andsppark(=0.1.11) inrust/Cargo.toml. - Update
rust/Cargo.lockto resolve to the pinnedsupraseal-c2/spparkversions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/Cargo.toml | Introduces manifest-level pins intended to hold the SupraSeal GPU stack at pre-regression versions. |
| rust/Cargo.lock | Updates the resolved dependency graph to use the pinned supraseal-c2/sppark versions (and includes an additional unrelated resolution change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Got some engagement @ supranational/sppark#81 (comment), will wait and see, interesting point made there but the net result might be that we essentially go down the revert path for that change anyway and end up somewhere close to what this PR is doing. We can wait though unless SPs start to express urgency about this. |
|
supranational/sppark@01e723f original change got reverted, so we're in a similar state upstream as we would be here with a revert, will wait for a bit to see if we can get a release for it |
|
Closing this PR since we got a release for it, which was updated in: #582 |
sppark 0.1.12+ leaks GPU memory under FFI_USE_CUDA_SUPRASEAL=1, OOMing long-lived lotus-miner/lotus-worker processes. Hold supraseal-c2 at 0.1.1 and sppark at 0.1.11 until upstream ships a fix.
Ref: filecoin-project/lotus#13634, supranational/sppark#81
We don't necessarily have to pull the trigger on this, but we can if we don't get movement upstream and/or this causes problems for SPs and they really need it fixed ASAP.