Skip to content

fix(deps): pin supraseal-c2/sppark to pre-regression versions - #578

Closed
rvagg wants to merge 1 commit into
masterfrom
rvagg/sppark-pin
Closed

fix(deps): pin supraseal-c2/sppark to pre-regression versions#578
rvagg wants to merge 1 commit into
masterfrom
rvagg/sppark-pin

Conversation

@rvagg

@rvagg rvagg commented May 25, 2026

Copy link
Copy Markdown
Member

sppark 0.1.12+ leaks GPU memory under FFI_USE_CUDA_SUPRASEAL=1, OOMing long-lived lotus-miner/lotus-worker processes. Hold supraseal-c2 at 0.1.1 and sppark at 0.1.11 until upstream ships a fix.

Ref: filecoin-project/lotus#13634, supranational/sppark#81


We don't necessarily have to pull the trigger on this, but we can if we don't get movement upstream and/or this causes problems for SPs and they really need it fixed ASAP.

sppark 0.1.12+ leaks GPU memory under FFI_USE_CUDA_SUPRASEAL=1,
OOMing long-lived lotus-miner/lotus-worker processes. Hold
supraseal-c2 at 0.1.1 and sppark at 0.1.11 until upstream ships a
fix.

Ref: filecoin-project/lotus#13634, supranational/sppark#81
Copilot AI review requested due to automatic review settings May 25, 2026 11:46
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz May 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the CUDA SupraSeal dependency chain to known-good versions to avoid a reported GPU memory leak in sppark when building/running with FFI_USE_CUDA_SUPRASEAL=1, protecting long-lived Lotus miner/worker processes from OOM.

Changes:

  • Add explicit version pins for supraseal-c2 (=0.1.1) and sppark (=0.1.11) in rust/Cargo.toml.
  • Update rust/Cargo.lock to resolve to the pinned supraseal-c2/sppark versions.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
rust/Cargo.toml Introduces manifest-level pins intended to hold the SupraSeal GPU stack at pre-regression versions.
rust/Cargo.lock Updates the resolved dependency graph to use the pinned supraseal-c2/sppark versions (and includes an additional unrelated resolution change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rust/Cargo.toml

@rjan90 rjan90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinged in stack-leads channel asking if anyone has contacts over at supranational. That said, we can also consider shipping a release with the nv29 in the short-term: #580 and bump version again once fixed upstream

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz May 27, 2026
@rvagg

rvagg commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

Got some engagement @ supranational/sppark#81 (comment), will wait and see, interesting point made there but the net result might be that we essentially go down the revert path for that change anyway and end up somewhere close to what this PR is doing. We can wait though unless SPs start to express urgency about this.

@rvagg

rvagg commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

supranational/sppark@01e723f original change got reverted, so we're in a similar state upstream as we would be here with a revert, will wait for a bit to see if we can get a release for it

@rjan90

rjan90 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Closing this PR since we got a release for it, which was updated in: #582

@rjan90 rjan90 closed this Jun 9, 2026
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants