Merged
Conversation
FilOzzy
added
team/filecoin-pin
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a configuration parsing bug in the Filecoin Pin integration where session-key auth defaults were being applied too early, causing “conflicting authentication” errors when a private key was provided.
Changes:
- Stop defaulting
VITE_WALLET_ADDRESS/VITE_SESSION_KEYat read-time so presence checks reflect only explicitly provided env vars. - Build an
authobject first, then spread it intofilecoinPinConfigso only one auth mode is included. - Keep the “conflicting authentication” guard while allowing private-key auth without accidentally enabling session-key auth.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
working on the lockfile error in #169 |
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, when you pass a private key, you get this error, because the config always defaults empty wallet address and session key to default values: