Skip to content

fix upload-action: pnpm needs version#393

Merged
juliangruber merged 5 commits intomasterfrom
fix/upload-action-pnpm-version
Apr 1, 2026
Merged

fix upload-action: pnpm needs version#393
juliangruber merged 5 commits intomasterfrom
fix/upload-action-pnpm-version

Conversation

@juliangruber
Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings April 1, 2026 10:35
@FilOzzy FilOzzy added team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board. labels Apr 1, 2026
@juliangruber juliangruber force-pushed the fix/upload-action-pnpm-version branch from e65a4cd to 10e48bd Compare April 1, 2026 10:35
@FilOzzy FilOzzy added this to FOC Apr 1, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Apr 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the upload-action composite GitHub Action to explicitly configure the pnpm version during setup, addressing failures with pnpm/action-setup@v4 when no version is inferred.

Changes:

  • Add an explicit pnpm version input to the pnpm/action-setup@v4 step used by the upload composite action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread upload-action/action.yml
@juliangruber juliangruber changed the title fix: fix upload-action: pnpm needs version fix upload-action: pnpm needs version Apr 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread upload-action/action.yml Outdated
Comment thread upload-action/action.yml
Comment thread upload-action/action.yml
juliangruber and others added 3 commits April 1, 2026 12:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread upload-action/action.yml
@jennijuju jennijuju self-requested a review April 1, 2026 11:03
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Apr 1, 2026
@juliangruber juliangruber merged commit 2172056 into master Apr 1, 2026
16 checks passed
@juliangruber juliangruber deleted the fix/upload-action-pnpm-version branch April 1, 2026 11:07
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/filecoin-pin "Filecoin Pin" project is a stakeholder for this work. team/fs-wg FOC working group is a stakeholder for this work, and thus wants to track it on their project board.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants