feat: compact data-set list output#580
Merged
BravoNatalie merged 8 commits intoJun 24, 2026
Merged
Conversation
BravoNatalie
requested changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the filecoin-pin data-set list / ls CLI flow to render a compact, one-row-per-data-set table (while keeping the existing detailed rendering for show, piece-status, and termination flows).
Changes:
- Added
displayDataSetList()compact renderer and switchedrunDataSetListCommand()to use it. - Updated CLI unit tests to distinguish between compact list rendering vs detailed rendering.
- Added unit tests for the new compact list output formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/data-set/run.ts | Switches data-set list to use the new compact renderer. |
| src/data-set/display.ts | Adds displayDataSetList() and supporting helpers for compact table output. |
| src/test/unit/data-set.test.ts | Updates mocks/assertions to reflect the new renderer split (displayDataSetList vs displayDataSets). |
| src/test/unit/data-set-display.test.ts | New unit tests covering compact table output behavior. |
| src/test/unit/core-data-set.test.ts | Updates piece-size mocking used by core data-set tests (currently inconsistent with runtime usage). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BravoNatalie
requested changes
Jun 18, 2026
BravoNatalie
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good, but I have one point about the changes in get-data-set-pieces.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #578
This updates
filecoin-pin data-set list/lsto use a compact one-row-per-data-set table while keeping detailed output fordata-set show,piece-status, and termination flows.The compact list now includes:
IDStatusProvider IDPiecesSizeCDNImplementation
src/core/data-set/.getActivePieces.getSizeFromPieceCID.unknown.displayDataSetList()for compact table rendering.runDataSetListCommand()to use the compact renderer.Visual Evidence
Before,
data-set listused the same detailed multi-section renderer asshow.After,
data-set listrenders compact rows like:Verification
Passed: