revert: configure release-please for proper semver (#582)#583
Closed
SgtPooki wants to merge 1 commit into
Closed
Conversation
This reverts commit bad16db.
FilOzzy
added
team/filecoin-pin
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts PR #582’s changes to release-please configuration to restore the previous release-please behavior, so a follow-up PR can re-apply the semver configuration together with the missing Release-As: 1.0.1 trailer (preserved via a merge commit) and avoid re-generating an invalid 1.0.0 release PR.
Changes:
- Revert
bump-minor-pre-majorandbump-patch-for-minor-pre-majorback totrue. - Re-add
always-bump-patchin the release-please config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Consolidating into a single one-line PR; see replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #582. That change was correct, but its squash merge dropped the commit body and the
Release-As: 1.0.1trailer, so release-please recomputed PR #566 to 1.0.0 (already taken on npm and the v1.0.0 tag).Reverting restores a clean base. The follow-up PR re-applies the same semver config together with the
Release-As: 1.0.1trailer, merged via a merge commit so the trailer reaches master.Do not merge release PR #566 until both this and the follow-up have landed.