Add observer metrics - #1042
Merged
Merged
Conversation
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Contributor
Author
|
@rvagg I would appriciate a post-review, I'm going to merge this when CI passes. |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Prometheus metrics collection to the observer component, enabling monitoring of message processing and rotation operations. The changes introduce OpenTelemetry-based metrics with an optional HTTP endpoint for metrics export.
- Adds OpenTelemetry and Prometheus dependencies for metrics collection
- Implements metrics tracking for message reception and rotation operations
- Creates an optional
/debug/metricsHTTP endpoint for Prometheus scraping
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| observer/metrics.go | New file defining OpenTelemetry metrics for rotations and messages received |
| observer/observer.go | Integrates metrics collection into message processing and adds optional metrics HTTP endpoint |
| observer/options.go | Adds configuration option for enabling metrics export |
| observer/query.go | Removes serveMux method (functionality moved inline) |
| cmd/f3/observer.go | Enables metrics export by default in observer command |
| go.mod | Updates OpenTelemetry dependencies and adds Prometheus client |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
- Coverage 64.91% 64.68% -0.24%
==========================================
Files 80 80
Lines 9733 9751 +18
==========================================
- Hits 6318 6307 -11
- Misses 2914 2938 +24
- Partials 501 506 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.