Conversation
The CEK-recovery helper still called ecdhkw.Unwrap with the old two-argument signature, breaking the build. Feed it the recipient's protected header bytes, the same way unwrapper.go does. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net> Assisted-by: Claude:claude-opus-5[1m]
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build break caused by an outdated ecdhkw.Unwrap call in the CEK-recovery test helper by passing the recipient protected header bytes, matching the current ecdhkw.Unwrap signature and the production unwrapper behavior.
Changes:
- Extract the recipient’s protected header bytes via
rcpt.Headers.ProtectedBytes(). - Pass the protected header bytes into
ecdhkw.Unwrap(...)as the third argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alanshaw
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CEK-recovery helper still called ecdhkw.Unwrap with the old two-argument signature, breaking the build. Feed it the recipient's protected header bytes, the same way unwrapper.go does.