-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gateway): add new methods #12727
Conversation
@@ -34,6 +35,12 @@ import ( | |||
// * Generate openrpc blobs | |||
|
|||
type Gateway interface { | |||
ChainGetNode(ctx context.Context, p string) (*IpldObject, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this one @dumikau ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I can't see this one making it to the v2 API that's under development now without a really good use-case, are people asking for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this method was added by request of a user from Neti-Soft
StateMinerSectors(context.Context, address.Address, *bitfield.BitField, types.TipSetKey) ([]*miner.SectorOnChainInfo, error) | ||
StateMinerFaults(context.Context, address.Address, types.TipSetKey) (bitfield.BitField, error) | ||
StateMinerAvailableBalance(context.Context, address.Address, types.TipSetKey) (types.BigInt, error) | ||
StateMarketParticipants(context.Context, types.TipSetKey) (map[string]MarketBalance, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one isn't small - mainnet currently gives a map with 6175
entries, 361Kb of JSON. It's not inefficient, so probably not too big a problem to expose, except for the fact that it's a big chunk of data for a simple call. Are people asking for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all these methods were added by requests of different users
|
I'm not completely against |
2025-02-10 maintainer conversation: next steps are for @dumikau to either:
|
Thank you for submitting the PR and contributing to lotus! Lotus maintainers need more of your input before merging it, please address the suggested changes or reply to the comments or this PR will be closed in 72 hours. You are always more than welcome to reopen the PR later as well! |
Closing since it has been over 72 hours, and stalebot was unable to close. |
No description provided.