feat: count the base "block open" fee against memory retention - #1413
Closed
Stebalien wants to merge 1 commit into
Closed
feat: count the base "block open" fee against memory retention#1413Stebalien wants to merge 1 commit into
Stebalien wants to merge 1 commit into
Conversation
This effectively removes the memory retention fee from newly opened blocks. The cross-over point is ~44MiB.... This will save about 4.4K gas per 1K block opened (about 2% of the total gas value). Not much, but it helps a bit.
Stebalien
force-pushed
the
feat/reduce-memory-retention-again
branch
from
January 10, 2023 19:23
101dcd0 to
1b82836
Compare
Stebalien
marked this pull request as draft
January 12, 2023 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively removes the memory retention fee from newly opened blocks. The cross-over point is ~44MiB....
This will save about 4.4K gas per 1K block opened (about 2% of the total gas value). Not much, but it helps a bit.
Really, the main reason I made this PR is that it simplifies the FIP a bit. Now I can just talk about the total block open gas charge as:
min(min_gas_retention_per_byte * size, block_open_fee)