Add create WASM module level function#1821
Closed
sistemd wants to merge 1 commit intofilecoin-project:masterfrom
Closed
Add create WASM module level function#1821sistemd wants to merge 1 commit intofilecoin-project:masterfrom
create WASM module level function#1821sistemd wants to merge 1 commit intofilecoin-project:masterfrom
Conversation
Contributor
|
Hey! 👋 As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR? 1. Close it: If it's no longer needed. If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know. Thanks for your help in keeping things organized, and I appreciate your contributions! |
Contributor
Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #746. Adds new
createconstructor entrypoint for actors. This allows the calling convention for constructors to change. At the moment:paramsblock ID is passed. I think that this is a good way to do it, and the consistency of passing everything as an IPLD block is valuable IMO.invokeentrypoint can use it for whatever it wants.createcall is charged the same gas as if it were a send. It's treated as a call equal toinvoke.create_actorsyscall in the init actor.Related updates to the builtin actors: filecoin-project/builtin-actors#1339.