chore(deps): upgrade wasmtime to 36 - #2226
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2226 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 147 147
Lines 15789 15789
=======================================
Hits 12250 12250
Misses 3539 3539 🚀 New features to boost your workflow:
|
|
Also needs a look over fvm/src/engine/mod.rs and the wasmtime CHANGELOG at the same time to (1) check what's changed and whether we have conflicts with our existing settings, and (2) add anything new and ideally set it explicitly. In particular we have to be careful of newer features that add nondeterminism, features that interfere with our gas accounting, or bring in risk features that may cause instability across our deployment environments. |
|
Quick scan, this one stands out in v37, see the note in mod.rs about GC:
There's some work on the exceptions feature in there too, I'm not sure if that's in config yet. It might not be something we can touch if we don't enable the |
|
Hey @rvagg Updating wasmtime to 37 requires more changes like bumping MSRV and fixing a few compilation errors, so this PR uses 36. Please let me know if you prefer going straight to 37 and I will try to fix everything. |
|
oh right, I missed that; 36 is fine for now I guess, we should do Rust version as a separate step and it's going to have flow-on consequences to other repos so that's a job in itself |
Some tipset validation benchmarks to justify the upgrade: (No significant latency or memory usage change observed)
wasmtime@31+mainnet@5412980
wasmtime@36+mainnet@5412980
wasmtime@31+calibnet@3111900
wasmtime@36+calibnet@3111900
Related PR: ChainSafe/forest#6167