feat: f02 mocks - #16
Merged
Merged
Conversation
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-4-6
Closed
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-5
Assisted-by: Claude:claude-sonnet-4-6
…ites Assisted-by: Claude:claude-sonnet-4-6
…checks Assisted-by: Claude:claude-sonnet-4-6
Assisted-by: Claude:claude-sonnet-4-6
Assisted-by: Claude:claude-sonnet-4-6
Assisted-by: Claude:claude-sonnet-4-6
rvagg
approved these changes
Aug 10, 2026
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
👌 really nice work
I'm going to follow up with a PR, or some stacked PRs to bring it up to the current spec since some things changed since this was written, and I'll also add some fixtures for encoded forms so we can be assured about the cbor
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Based on the #13 design
Main files are:
src/lib/FVMRewards.soltest/mocks/FVMRewardActor.solThese mocks, in the style of the mocks in
fvm-solidityMockFVMTest's etched mocks, provide a Solidity test harness that can run in forge's EVM.The main goal of such mocks is to match the behavior of builtin-actors, which will help test #3 and #4.
It is not important for the mocks to be efficient.
This can merge before the builtin-actors change (filecoin-project/builtin-actors#1764), but will need to be updated when that lands.