Skip to content

Fix: Fixed issue where right clicking a folder in Columns View would open it - #18600

Merged
yair100 merged 1 commit into
mainfrom
ya/ColumnsRightClick
Jun 16, 2026
Merged

Fix: Fixed issue where right clicking a folder in Columns View would open it#18600
yair100 merged 1 commit into
mainfrom
ya/ColumnsRightClick

Conversation

@yair100

@yair100 yair100 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Right clicked folder in Columns View
  2. Confirmed the folder was selected but didn't open
  3. Confirmed the open folder was closed
  4. Confirmed that clicking the selected folder again opened it

@yair100
yair100 requested a review from Josh65-2201 June 16, 2026 19:16
@Josh65-2201

Copy link
Copy Markdown
Member

Confirmed the open folder was closed

Not sure this should be done, to me it makes more sense that right clicking another folder should keep the existing one open in the next column.

@yair100

yair100 commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Confirmed the open folder was closed

Not sure this should be done, to me it makes more sense that right clicking another folder should keep the existing one open in the next column.

If we don't close the folder when another item is selected, it messes up the visual hierarchy of open folders.

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Jun 16, 2026
@yair100
yair100 merged commit 5883241 into main Jun 16, 2026
9 checks passed
@yair100
yair100 deleted the ya/ColumnsRightClick branch June 16, 2026 21:10
@yair100 yair100 changed the title Fix: Fixed issue where right clicking folder in Columns View opened it Fix: Fixed issue where right clicking a folder in Columns View would open it Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Right-clicking a directory in column view opens it

2 participants