Skip to content

Feature: Improved 'Open in new pane' context menu - #18602

Merged
yair100 merged 2 commits into
mainfrom
ya/Panes
Jun 16, 2026
Merged

Feature: Improved 'Open in new pane' context menu#18602
yair100 merged 2 commits into
mainfrom
ya/Panes

Conversation

@yair100

@yair100 yair100 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Resolved / Related Issues

Improved the 'Open in new pane' context menus throughout the app to allow choosing the split arrangement.

image

@yair100
yair100 requested a review from Josh65-2201 June 16, 2026 22:40
@yair100 yair100 added the ready for review Pull requests that are ready for review label Jun 16, 2026

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action is disabled if a pane is open, 4.1.3 doesn't disable it.

@yair100

yair100 commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

This is by design, we only allow two panes at a given time. If there is enough interest, we can add another action to 'Open in other pane'.

@Josh65-2201

Copy link
Copy Markdown
Member

Why not rename it Open in pane that wording would allow both new and existing, then the action can replace the other panes folder like 4.1.3 does

@yair100

yair100 commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

The current behavior is outdated and dates back to before Files had support for changing the pane arrangement. The reason the behavior needs to change with this PR is that it allows users to choose the arrangement of the new pane. If Dual Pane is already active, we can't let users choose the pane arrangement since they aren't opening a new pane, they are opening a folder in an existing pane.

That being said, we can replace 'Open in new pane' with 'Open in other pane' when Dual Pane is already active.

@yair100
yair100 merged commit 4f15868 into main Jun 16, 2026
8 of 9 checks passed
@yair100
yair100 deleted the ya/Panes branch June 16, 2026 23:40
@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants