Skip to content

Feature: Open a new tab by middle clicking empty tab space #18658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
0x5bfa wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Draft

Feature: Open a new tab by middle clicking empty tab space #18658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Files.App/Views/MainPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using Windows.Foundation.Metadata;
using Windows.Graphics;
using Windows.UI.Input;
using Windows.Win32;
using WinUIEx;
using GridSplitter = Files.App.Controls.GridSplitter;
using VirtualKey = Windows.System.VirtualKey;
Expand All @@ -32,8 +33,10 @@ public sealed partial class MainPage : Page
public MainPageViewModel ViewModel { get; }

private bool keyReleased = true;
private const int KEY_DOWN_MASK = 0x8000;

private DispatcherQueueTimer _updateDateDisplayTimer;
private InputNonClientPointerSource? _nonClientPointerSource;

private readonly Dictionary<TabBarItem, double> _sidebarScrollByTab = new();
private TabBarItem? _previousSidebarTab;
Expand Down Expand Up @@ -122,6 +125,15 @@ private int SetTitleBarDragRegion(InputNonClientPointerSource source, SizeInt32
return height;
}

private async void NonClientPointerSource_PointerPressed(InputNonClientPointerSource sender, NonClientPointerEventArgs args)
{
if (args.RegionKind is not NonClientRegionKind.Caption ||
(PInvoke.GetKeyState((int)VirtualKey.MiddleButton) & KEY_DOWN_MASK) == 0)
return;

await NavigationHelpers.AddNewTabAsync();
}

public async void TabItemContent_ContentChanged(object? sender, TabBarItemParameter e)
{
if (SidebarAdaptiveViewModel.PaneHolder is null)
Expand Down Expand Up @@ -297,6 +309,12 @@ private void Page_Loaded(object sender, RoutedEventArgs e)
FindName(nameof(TabControl));
FindName(nameof(NavToolbar));

if (_nonClientPointerSource is null)
{
_nonClientPointerSource = InputNonClientPointerSource.GetForWindowId(MainWindow.Instance.AppWindow.Id);
_nonClientPointerSource.PointerPressed += NonClientPointerSource_PointerPressed;
}

// Notify user that drag and drop is disabled
// Prompt is disabled in the dev environment to prevent issues with the automation testing
// ToDo put this in a StartupPromptService
Expand Down
Loading