Skip to content

Code Quality: Moved Checkout operation into Git abstraction#18669

Draft
Lamparter wants to merge 2 commits into
files-community:mainfrom
Lamparter:libgit2/Checkout
Draft

Code Quality: Moved Checkout operation into Git abstraction#18669
Lamparter wants to merge 2 commits into
files-community:mainfrom
Lamparter:libgit2/Checkout

Conversation

@Lamparter

Copy link
Copy Markdown
Contributor

Resolved / Related Issues

Steps used to test these changes

The implementation is logically identical to the previous, it has just been moved.

@CLAassistant

CLAassistant commented Jul 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@yair100 yair100 added the ready for review Pull requests that are ready for review label Jul 1, 2026
@yair100

yair100 commented Jul 2, 2026

Copy link
Copy Markdown
Member

IsExecutingGitAction is now set in the LibGit2 instance, but ContentPageContext and BaseShellPage still read from the static GitHelpers.IsExecutingGitAction.

@Lamparter

Copy link
Copy Markdown
Contributor Author

Oops, I must have overlooked that. I'll fix it ASAP

@Lamparter

Copy link
Copy Markdown
Contributor Author

blocked until #18679 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants