feat: implement I.2 names generator and third_party org - #10
Merged
Conversation
Moved names.txt to //third_party/names and added SSA LICENSE. Created a generator in //internal/names/gen to convert names.txt into a Go slice during the bazel build, removing the need for runfiles at runtime. This commit has been created by an automated coding assistant, with human supervision. Prompt: move names to //third_party/names, add LICENSE for it from where you downloaded the list, and fix up references in the source put names.go back where it was, only names.txt must be in third_party. also, create a generator that converts the names.txt into go code which is then included into the binary, so that it doesn't need to be added as rlocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
names.txtvia runfiles with compile-time generation. A new generatorgen.goprocessesnames.txtinto a Go slice, which is then compiled into the binary. Added tests to verify name generation.names.txtfrominternal/namestothird_party/namesand added the SSA license file attributing the data to the US Social Security Administration public domain dataset.main.goand verified internal/names imports.This pull request has been created by an automated coding assistant,
with human supervision.
Prompt:
send PR against main