Skip to content

Make qos_fill and qos_stop local for each thread in sparsebytemap #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 17, 2025

Conversation

Paramuths
Copy link
Collaborator

No description provided.

@willow-ahrens willow-ahrens enabled auto-merge April 22, 2025 21:01
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/architecture.jl 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/postprocess.jl 89.13% <100.00%> (-0.39%) ⬇️
src/tensors/levels/sparse_bytemap_levels.jl 84.18% <ø> (ø)
src/architecture.jl 58.53% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Paramuths Paramuths disabled auto-merge May 16, 2025 19:10
@Paramuths Paramuths changed the title Fix deadcode error on break Make qos_fill and qos_stop local for each thread in sparsebytemap May 16, 2025
@Paramuths Paramuths requested a review from willow-ahrens May 16, 2025 19:11
Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove that dep from project.toml and this is good to go!

@@ -254,8 +254,8 @@ function distribute_level(
distribute_buffer(ctx, lvl.tbl, arch, style),
distribute_buffer(ctx, lvl.srt, arch, style),
lvl.shape,
lvl.qos_fill,
lvl.qos_stop,
distribute_buffer(ctx, lvl.qos_fill, arch, style),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was such a simple fix. Thank you so much!

@willow-ahrens willow-ahrens enabled auto-merge May 17, 2025 20:46
Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind about the tensormarket dep, I read the diff wrong

@willow-ahrens willow-ahrens merged commit e50b9b8 into main May 17, 2025
8 checks passed
@willow-ahrens willow-ahrens deleted the parallel_scheduler branch May 17, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants