services/turnstiled: init by xZecora · Pull Request #22 · finix-community/community-modules

xZecora · 2026-06-29T23:02:36Z

initial commit for the turnstiled service. currently very barebones

aanderse · 2026-06-30T02:41:37Z

awesome! please hold off merging for a few days, i would like to share some related dinit work i have been doing so we can potentially integrate

aanderse

very cool! this will work so well with the dinit.services and dinit.user.services options i have written!

aanderse · 2026-06-30T19:52:26Z

+  ];
+
+  patches = [
+    ./patch.diff


/run/current-system/sw/bin/dinit-monitor is less than ideal, especially if we're already linking against dinit - how about:

postPatch = '' substituteInPlace backend/dinit \ --replace-fail '/usr/bin/dinit-monitor' '${lib.getExe' dinit "dinit-monitor"}' '';

and if we're doing that we could inline the patch to meson.build to simplify (ie. drop patch.diff):

substituteInPlace meson.build \ --replace-fail "get_option('prefix'), get_option('sysconfdir'), 'turnstile'" "'/etc', 'turnstile'"

Agreed, didn't think of this while I was writing it. Changed in latest commit.

aanderse · 2026-06-30T19:53:32Z

+    "-Ddefault_backend=dinit"
+    "-Ddinit=enabled"
+    "-Dstatedir=/var/lib/turnstiled"
+    "-Dpam_moddir=./pam"


is that right? 🤔

aanderse · 2026-06-30T19:54:11Z

+  mesonFlags = [
+    "-Ddefault_backend=dinit"
+    "-Ddinit=enabled"
+    "-Dstatedir=/var/lib/turnstiled"


isn't that already the value? if not, sounds like we need to modify localstatedir instead?

aanderse · 2026-06-30T19:56:26Z

+
+stdenv.mkDerivation {
+  pname = "turnstile";
+  version = "0-unstable-2025-12-15";


worth pinning to version 0.1.11, only one irrelevant commit off this... makes it easier to upstream into nixpkgs, which should definitely be a goal of ours

Good point, pinned it in latest commit.

aanderse · 2026-06-30T20:05:53Z

+              enableGraphicalMonitor = mkOption {
+                type = bool;
+                default = false;
+                description = "Whether or not to monitor environment changes to DISPLAY and WAYLAND_DISPLAY variables. Currently requires manually adding `dinitctl setenv VAR=$VAR`to any startup scripts for your graphical environment to function.";
+              };


i'm not sure we should actually have this as an option at all... and if we should, then it should be configured via services.turnstiled.package = pkgs.turnstiled.override { enableGraphicalMonitor = false; }; or something along those lines

I'm relatively neutral on the idea, the main purpose of the option was to allow an immediately obvious way to disable them for people looking at the options from a non-source code position. Like I said though, no strong opinion, happy to remove if you think its best to make it transparent.

Decision might also depend on how we resolve this comment so I figured I'd leave it unchanged for now.

aanderse · 2026-06-30T20:07:37Z

+              service_dir = mkOption {
+                type = str;
+                default = "$HOME/.config/dinit.d";
+                description = "Users service dir for `turnstile`'s `dinit` backend. This should include a way to differentiate per user unless all users have identical services.";
+              };
+
+              boot_dir = mkOption {
+                type = str;
+                default = "${cfg.dinit.service_dir}/boot.d";
+                description = "Users service boot dir for `turnstile`'s `dinit` backend. This should include a way to differentiate per user unless all users have identical services.";
+              };
+
+              system_boot_dir = mkOption {
+                type = path;
+                default = "/usr/lib/dinit.d/user/boot.d";
+                description = "Systems service boot dir for `turnstile`'s `dinit` backend.";
+              };


could we please put these under a settings key (key, not option)?

For sure, makes a lot of sense.

aanderse · 2026-06-30T20:09:16Z

+      "turnstile/backend/dinit.conf".text = ''
+        boot_dir="${cfg.dinit.boot_dir}"
+        system_boot_dir="${cfg.dinit.system_boot_dir}"
+        services_dir1="${cfg.dinit.service_dir}"
+        services_dir2="/etc/dinit.d/user"
+        services_dir3="/usr/local/lib/dinit.d/user"
+        services_dir4="/usr/lib/dinit.d/user"
+        			'';


Suggested change

"turnstile/backend/dinit.conf".text = ''

boot_dir="${cfg.dinit.boot_dir}"

system_boot_dir="${cfg.dinit.system_boot_dir}"

services_dir1="${cfg.dinit.service_dir}"

services_dir2="/etc/dinit.d/user"

services_dir3="/usr/local/lib/dinit.d/user"

services_dir4="/usr/lib/dinit.d/user"

'';

"turnstile/backend/dinit.conf".text = (pkgs.formats.keyValue { }).generate "dinit.conf" cfg.dinit.settings;

see comments above about adding services.turnstiled.dinit.settings option

Leaving unresolved because I think I want to change the services.turnstiled.dinit.settings.service_dir option to allow a list so users can change services_dir 2-4 and beyond. Makes the conversion a bit more complicated but I will definitely look into this

as much as i don't like opinionated modules... yes, that is so so so much better 😅

please 🙇‍♂️

aanderse · 2026-06-30T20:11:00Z

+    settings =
+      with lib;
+      mkOption {
+        type =
+          with types;
+          submodule {
+            options = {


Suggested change

settings =

with lib;

mkOption {

type =

with types;

submodule {

options = {

settings = {

not everything needs to be an option - in this case there is no actual advantage, and an extra submodule evaluation has to occur, so i would drop the mkOption and go with a raw attribute set for settings in this case

unoptioned settings

aanderse · 2026-06-30T20:11:47Z

+
+    configFile = lib.mkOption {
+      type = lib.types.path;
+      default = "/etc/turnstiled.conf";
+      description = "Configuration file location for tunrstiled";
+    };


Suggested change

configFile = lib.mkOption {

type = lib.types.path;

default = "/etc/turnstiled.conf";

description = "Configuration file location for tunrstiled";

};

unused, drop it 👍

xZecora added 3 commits June 29, 2026 18:34

services/turnstiled: init

4763af1

services/turnstiled: fixed formatting

6f64e18

services/turnstile: changed service name to turnstile from turnstiled

0baee21

aanderse requested changes Jun 30, 2026

View reviewed changes

xZecora added 2 commits July 1, 2026 17:25

services/turnstile: made requested changes to default.nix for quality

d6520e4

services/turnstile: made requested changes in package.nix for quality

2584e42

Uh oh!

Conversation

xZecora commented Jun 29, 2026

Uh oh!

aanderse commented Jun 30, 2026

Uh oh!

aanderse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants