Added Java Reference implementation for FDC3 API#1
Added Java Reference implementation for FDC3 API#1amanjmd wants to merge 3 commits intofinos-labs:mainfrom
Conversation
Signed-off-by: Aman Kapoor <amanjmd100@gmail.com>
Signed-off-by: Aman Kapoor <amanjmd100@gmail.com>
There was a problem hiding this comment.
I'm good with the initial contribution but I would suggest changing the package names as indicated.
We should then get this merged and raise issues for setting up checks (CI build, run tests, SAST (semver) etc..
@TheJuanAndOnly99, @robmoffat or @maoo can I assume you'd be ok with the proposed package name: org.finos.fdc3.appd and would you mind pointing us at advice for project maintainers on setting up checks etc.. I forget where all that is.
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| package com.fdc.appd.datasources; |
There was a problem hiding this comment.
Should consider changing all the namespaces to org.finos.fdc3.appd.*
There was a problem hiding this comment.
I'm good with the proposed package name org.finos.fdc3.appd. It follows our standard naming convention.
Recommend taking a look at FINOS code scanning repo for info on setting up CVE and License checks. You can refer to https://github.com/finos/spring-bot as an example.
|
@robmoffat, as an experienced Java dev, would you be up for offering some help on this project? Pointing out an example java project else where in FINOS to copy checks etc. from would be useful. |
Signed-off-by: Aman Kapoor <amanjmd100@gmail.com>
|
Hi @kriswest / @robmoffat, I have modified the package declaration to the below package org.finos.fdc3.appd.* Let me know in case any further modifications are required . |
3 participants
Signed-off-bystatement (use--signoffin the commit).By submitting this pull request, I certify that I have read and agree to the terms of the Developer Certificate of Origin.