-
Notifications
You must be signed in to change notification settings - Fork 164
Context Clearing #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kemerava
merged 24 commits into
finos:1197-context-clearing
from
kemerava:feature/context-clearing
Jul 29, 2025
Merged
Context Clearing #1379
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d9541d1
Context Clearing
kemerava 77e2b61
Apply suggestions from code review
kemerava a2c348e
Changelog and fixing the name of the field
kemerava 60456c3
Merge remote-tracking branch 'origin/main' into feature/context-clearing
kemerava 768f50d
Adding conformance tests
kemerava acac1a0
Apply suggestions from code review
kemerava a4106fe
Merge remote-tracking branch 'origin/main' into feature/context-clearing
kemerava 4e2bc61
Merge branch 'main' into feature/context-clearing
kriswest c66f420
Merge remote-tracking branch 'origin/main' into feature/context-clearing
kemerava cdeea6a
Adding addEventListener for listening on clearing context
kemerava 1ad0c4a
Clearing context tests
kemerava a732bcc
Fixing package-lock.json
kemerava 9c79048
Making build pass
kemerava 04507e0
Merge remote-tracking branch 'origin/main' into feature/context-clearing
kemerava e21ec30
Adding the event for the contextCleared
kemerava 90c8fab
npm
kemerava c63e1d4
PR review changes
kemerava b953954
Merge remote-tracking branch 'origin/main' into feature/context-clearing
kemerava bc5c98c
Update CHANGELOG.md
kemerava c572444
Merge branch 'feature/context-clearing' of https://github.com/kemerav…
kemerava 90a06e3
Update website/docs/api/ref/Channel.md
kemerava ac73c5c
Updating based on reviews
kemerava 6d22fb3
Typo
kemerava a7e5c4b
Update lang
kemerava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should require an explicit null argument (
contextType: string | null) to clear all types - which would matchaddContectListeneror stick with this (matchinggetCurrentContext). Either works of course.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it makes sense to keep it closer to getCurrentContext, because they seem most related to me, but happy to hear any thoughts/suggestions.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a historical reason for
addContextListenerhaving an explicit null argument, thecontextTypeargument was originally optional so thehandlerargument could be either first or second (when a type was specified). This was NOT good in practice so we moved to an explicitnullargument and deprecated the single argument override:https://fdc3.finos.org/docs/2.0/api/ref/DesktopAgent#addcontextlistener-deprecated
We don't have that problem here, so I agree its fine as is (matching
getCurrentContext).