Adding language binding for golang

[kemerava]

Describe your change

Adding golang language binding
@michael-bowen-sc

Review deeplinks:

• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/supported-platforms#go
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/DesktopAgent
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/Channel
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/PrivateChannel
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/Types
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/Metadata
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/Errors
• https://deploy-preview-1483.preview-fdc3.finos.org/docs/next/api/ref/Events

Related Issue

#1482

Contributor License Agreement

• I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

• Issue: If a change was made to the FDC3 Standard, was an issue linked above?
• CHANGELOG: Is a CHANGELOG.md entry included?
• API changes: Does this PR include changes to any of the FDC3 APIs (DesktopAgent, Channel, PrivateChannel, Listener, Bridging)?
  • Docs & Sources: If yes, were both documentation (/docs) and sources updated?
    
    JSDoc comments on interfaces and types should be matched to the main documentation in /docs
  • Conformance tests: If yes, are conformance test definitions (/toolbox/fdc3-conformance) still correct and complete?
    
    Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
  • Schemas: If yes, were changes applied to the Bridging and FDC3 for Web protocol schemas?
    
    The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
    • If yes, was code generation (npm run build) run and the results checked in?
      
      Generated code will be found at /src/api/BrowserTypes.ts and/or /src/bridging/BridgingTypes.ts
• Context types: Were new Context type schemas created or modified in this PR?
  • Were the field type conventions adhered to?
  • Was the BaseContext schema applied via allOf (as it is in existing types)?
  • Was a title and description provided for all properties defined in the schema?
  • Was at least one example provided?
  • Was code generation (npm run build) run and the results checked in?
    
    Generated code will be found at /src/context/ContextTypes.ts
• Intents: Were new Intents created in this PR?
  • Were the intent name prefixes and other naming conventions & characteristics adhered to?
  • Was the new intent added to the list in the Intents Overview?

[netlify]

✅ Deploy Preview for fdc3 ready!

Name	Link
🔨 Latest commit	4424cc3
🔍 Latest deploy log	https://app.netlify.com/sites/fdc3/deploys/6824ddec7cbcb3000894233b
😎 Deploy Preview	https://deploy-preview-1483.preview-fdc3.finos.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kriswest]

Looks like a great contribution @kemerava 👏

I've given it a quick pass for typos and indentation consistency, see comments.

I think we could do with a subsection adding here on Go: https://deploy-preview-1483--fdc3.netlify.app/docs/next/api/supported-platforms#native
Please describe any idiosyncracies specific to the language. If you intend to contribute a repo with the binding to FINOS it can also be mentioned there.

[kriswest]

check indentation

[kemerava]

Fixed

[kemerava]

Thank you so much @kriswest for the review! (Sorry about the indentation madness, looks like this new IDE does not do spell checks or any indents, should be better now). Also I have added a section about go in the supported platforms, let me know if this is the level of granularity that would be okay there. Thanks again!

[kemerava]

@kriswest I modified the definitions of Context, this will provide a better support for json of context looking like it is supposed to, without modifying it and also it would make it possible to create other types of contexts (rather than just adding the other fields as part of the map in Context type. However, now it is a bit awkward with having all Context types implement one function. This is just the trade off that had to be made because of go's peculiarities

[kriswest]

Spotted a small issue rendering the code blocks on the supported platforms page

[kemerava]

Spotted a small issue rendering the code blocks on the supported platforms page

Thanks for the spot @kriswest! Fixed now!

[kriswest]

/netlify

[kemerava]

@kriswest could you please review the changes with experimental tag. Thanks!

[kriswest]

Closing to reopen in case that fixes the preview issues

[kriswest]

@TheJuanAndOnly99 can you ask netlify to rebuild this preview? I don't think it accepts commands from me and closing/reopening didn't affect it (did re-run the github actions however).

[kriswest]

@TheJuanAndOnly99 Ideally I'm after it using your later config so it gets a preview URL i can view ;-) But I'd settle for it just successfully building

[kriswest]

The changelog needs adjusting after the 2.2 release. Otherwise have suggested a few places to put @experimental.

Will be able to review properly once we get the preview fixed!

[TheJuanAndOnly99]

Hi @kriswest I triggered the preview build https://app.netlify.com/sites/fdc3/deploys/681b9118a04a5583475bab9a. It's still failing here. I think @kemerava will need to pull the changes to this branch as it does not have the updates to the .nvmrc file from main. Once you do so let me know and I can trigger the preview build again.

[kriswest]

@kemerava try merging main and then npm install in website/ and see if you get an integrity error. If not and it will then npm start ok that should sort it out. If you get an integrity error try blowing away the package-lock.json and installing again.

I think we may have ended up with bad checksum in the package-lock.json at some point (probably a bad merge), as there have been a few PRs with this error.

[kemerava]

@kemerava try merging main and then npm install in website/ and see if you get an integrity error. If not and it will then npm start ok that should sort it out. If you get an integrity error try blowing away the package-lock.json and installing again.

I think we may have ended up with bad checksum in the package-lock.json at some point (probably a bad merge), as there have been a few PRs with this error.

@kriswest ran both, and there were some changes in the package-lock, so I committed. Hopefully that resolves it

[kriswest]

@kemereva that did indeed fix the build, but there's a syntax error in the markdown to sort: https://app.netlify.com/sites/fdc3/deploys/681cd79fbf8e800009f1052a#L423

[kemerava]

@kriswest thanks for noticing, I fixed those errors, now the build is no longer failing

[kriswest]

LGTM
@hughtroeger or @novavi could you take a look?

[hughtroeger]

Well I don't know Go, but all the examples in the site previews look good and I didn't see any typos or other issues. 👍

[chriscasola]

Is there a Go library that implements the FDC3 schema and code behind the documentation in this PR? Sorry if that's an uneducated question.

[kriswest]

@chriscasola Not at present, we just have the API binding. However, @kemerava previously indicated a willingness to provide one or collaborate on one in future if there was interest in the Go binding. If you are interested I'd recommend raising an issue.

[kemerava]

Is there a Go library that implements the FDC3 schema and code behind the documentation in this PR? Sorry if that's an uneducated question.

Hi @chriscasola , there is not a library implementation at the moment. What are you looking for? The full implementation underneath the API or a library with the interfaces that can be pulled and implemented?