Update website to Docusaurus to 3.7.0#1502
Conversation
… into Issue#1371
… into 'sivaprasadanakarla-Issue#1371'
(looks someone merged 1.0, 1.1 and 1.2 files in the past accidentally - this commit unpicks that and reduces down to only files that were linked in the side-bar and therefore only files that were accessible/existed in that version)
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
|
|
|
|
Closing to repoen (in the hopes that it triggers the a fresh run of the npm-build workflow) |
Fix npm run version
|
|
|
@kriswest fixed the schema versioning problem here. |
|
|
|
/netlify |
|
|
julianna-ciq
left a comment
julianna-ciq
left a comment
There was a problem hiding this comment.
When I run docusuaurus build from website/package.json, I get an error
[ERROR] TypeError: Cannot read properties of undefined (reading 'vsDark')
at Object.<anonymous> (C:\...\website\docusaurus.config.js:52:54)
...
which refers to the line
"theme": require('prism-react-renderer').themes.vsDark.
Note that, while prism-react-renderer appears in package-lock.json and in node-modules, it does not appear in package.json's dependencies. Once I added this dep, the build errors went away.
| "additionalLanguages": ["typescript","javascript","json","csharp"], | ||
| "theme": require('prism-react-renderer/themes/vsDark') | ||
| "additionalLanguages": ["typescript", "javascript", "json", "csharp"], | ||
| "theme": require('prism-react-renderer').themes.vsDark |
There was a problem hiding this comment.
I'm getting build errors on this line because prism-react-renderer is not included as an explicit dependency in this package.
There was a problem hiding this comment.
oddly I don't get errors there (tested on a clean checkout) - but it doesn't hurt to resolve this regardless. Done!
|
@kriswest If the above issues are addressed before the SWG meeting tomorrow, I'm happy to approve the PR. |
|
|
|
|
Co-authored-by: Julianna Langston <[email protected]>
|
|
|
|
|
EasyCLA issues and the last set of review comments from @julianna-ciq are resolved - this should be ready to merge after a final check from any of the @finos/fdc3-desktop-agent-maintainers - then its onto the 2.2 release! |
6 participants
Describe your change
Updates the FDC3 website to 3.7.0 (superseding/incorporating PR #1418).
After updating a large number of broken links and anchors needed to fixed - docusaurus 2.x was much ore forgiving of capitalisation differences with links and anchors than 3.x. Further, it appears that some accidentally merged the files for version 1.0 -> 1.2 creating many duplicates with broken links. These are all fixed in this PR with only the correct files for each version retained.
Preview: https://deploy-preview-1502--fdc3.netlify.app/
Related Issue
resolves #1371
resolves #1516
Contributor License Agreement
Review Checklist