Skip to content

feat(context): add instrument classification property #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hughtroeger wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(context): add instrument classification property #1665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e1ced15
feat(context): add instrument classification property
hughtroeger Sep 16, 2025
3e66acc
Simplify schemas properties that reduce to string to improve generate…
kriswest Sep 19, 2025
2bc6c2e
refactor(instrument): move type enum into description
hughtroeger Sep 22, 2025
872b5e4
fixup: add generated files
hughtroeger Sep 22, 2025
7869d9e
refactor: convert classification from string to object
hughtroeger Oct 3, 2025
0f50e8c
refactor: change classification.fdc3 to classification.name
hughtroeger Oct 7, 2025
17f846d
use enum for FDS_TYPE
hughtroeger Nov 6, 2025
e4e2024
fixup: remove type suggestions from generic name field
hughtroeger Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]
* Enhanced method binding for FDC3 API objects to support destructuring. All public methods of `Channel`, `PrivateChannel`, and `IntentResolution` objects are now properly bound to their instances using `.bind(this)` in their constructors. ([#1645](https://github.com/finos/FDC3/issues/1645))

### Added
* Added a classification field to Instrument context type ([#1665](https://github.com/finos/FDC3/pull/1665))
* Enhanced method binding for FDC3 API objects to support destructuring. All public methods of `Channel`, `PrivateChannel`, and `IntentResolution` objects are now properly bound to their instances using `.bind(this)` in their constructors. ([#1645](https://github.com/finos/FDC3/issues/1645))
* Add a notes field to Trade type ([#1563](https://github.com/finos/FDC3/pull/1563))
* Add a notes field to Order and Product types ([#1597](https://github.com/finos/FDC3/pull/1597))
* Added Go language binding. ([#1483](https://github.com/finos/FDC3/pull/1483))
Expand Down Expand Up @@ -59,11 +60,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Setup package publishing for mono-repo packages. ([#1520](https://github.com/finos/FDC3/pull/1520))
* Implementation PR for FDC3 for the Web ([#896](https://github.com/finos/FDC3/pull/896))
- resolves ([#1209](https://github.com/finos/FDC3/issues/1209))
- resolves ([#1297](https://github.com/finos/FDC3/issues/1297))
- resolves ([#1429](https://github.com/finos/FDC3/issues/1429))
- resolves ([#1297](https://github.com/finos/FDC3/issues/1297))
- resolves ([#1429](https://github.com/finos/FDC3/issues/1429))
- resolves ([#1430](https://github.com/finos/FDC3/issues/1430))
- resolves ([#1431](https://github.com/finos/FDC3/issues/1431))
- resolves ([#1432](https://github.com/finos/FDC3/issues/1432))
- resolves ([#1432](https://github.com/finos/FDC3/issues/1432))
- resolves ([#1433](https://github.com/finos/FDC3/issues/1433))
- resolves ([#1468](https://github.com/finos/FDC3/issues/1468))
- resolves ([#810](https://github.com/finos/FDC3/issues/810))
Expand Down Expand Up @@ -96,7 +97,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Removed the `version` field from `IntentResolution` as there are no version fields for intents in the FDC3 API definitions and hence the field has no purpose. ([#1170](https://github.com/finos/FDC3/pull/1170))
* Fixed error in the Client-side example from `PrivateChannel` and `addIntentListener` by correcting `id.symbol` to `id.ticker` to align with the `fdc3.instrument` context. ([#1314](https://github.com/finos/FDC3/pull/1314))
* Added missing `resultType` argument to `findIntent` agent request in the Bridging Schema. ([#1154](https://github.com/finos/FDC3/pull/1154))
* Added missing `resultType` argument to `findIntentByContext` agent request in the Bridging Schema. ([#1212](https://github.com/finos/FDC3/pull/1212))
* Added missing `resultType` argument to `findIntentByContext` agent request in the Bridging Schema. ([#1212](https://github.com/finos/FDC3/pull/1212))
* Added missing id and name fields from the context base schema to respective context schemas (`Contact`, `ContactList`, `Country`, `InstrumentList`, `OrderList`, `Organization`, `Portfolio`, `Position`, `TradeList`). ([#1360](https://github.com/finos/FDC3/pull/1360))
* Revised FDC3 charter to include well-known language from the FDC3 introduction, better describe FDC3's scope, focus on financial applications, update application types, etc. ([#1079](https://github.com/finos/FDC3/pull/1079))
* Ensured that `PrivateChannelEvent` extends `ApiEvent` in both sourcecode and documentation. ([#1474](https://github.com/finos/FDC3/pull/1474))
Expand Down
Loading
Loading