Open
Conversation
Converts the standalone app-directory specification test into a proper Jest test that runs as part of CI. Changes: - Added test/AppDirectory.test.ts with tests for: - Valid API name and version - myApplication.json example validation - fdc3-workbench.json example validation - Added @apidevtools/swagger-parser and jsonschema to devDependencies - Removed src/app-directory/specification/test/ directory Closes #1716
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicates #1720
This PR duplicates the above but pushed to the finos repo rather than from an external repo. As far as I am aware I can't edit the other PR and add commits to it. This rebases the changes onto main and runs the test in vitest rather than jest as we do for all tests now.
Summary
Converts the standalone app-directory specification test from \src/app-directory/specification/test/\ into a proper Jest test that runs as part of CI.
Changes
Testing
Run the tests:
\\�ash
npm run test --workspace=@finos/fdc3-standard
\\
Closes #1716