Skip to content

Cucumber testing steps port - #1890

Open
robmoffat wants to merge 5 commits into
mainfrom
cucumber-testing-steps-port
Open

Cucumber testing steps port#1890
robmoffat wants to merge 5 commits into
mainfrom
cucumber-testing-steps-port

Conversation

@robmoffat

@robmoffat robmoffat commented May 19, 2026

Copy link
Copy Markdown
Member

Describe your change

This pull request updates the test infrastructure and standardized test step definitions. The main updates include switching from a custom/shared testing package to using Standard Cucumber Steps (to move into FINOS), updating test scenarios to use the new step syntax, and making minor improvements to developer tooling.

Test infrastructure and step definitions:

  • Replaced the internal @finos/testing package with standardized Cucumber steps from @robmoffat/standard-cucumber-steps and FDC3-specific steps from @finos/fdc3-schema/cucumber. This change is reflected in both package.json and documentation, and updates the source of generic test steps and utilities. [1] [2] [3] [4]
  • Updated all .feature test files in packages/fdc3-agent-proxy/test/features/ to use the new step syntax, replacing phrases like with parameter(s) or with parameters with using argument(s) or using arguments, to match the new standardized step definitions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

Developer tooling:

  • Added a new view script to packages/fdc3-agent-proxy/package.json for previewing test result HTML output with Vite.

These changes modernize the test setup, ensure better maintainability by using widely adopted Cucumber steps, and improve documentation and developer experience.

Related Issue

#1889

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?

@robmoffat
robmoffat requested a review from a team as a code owner May 19, 2026 16:06
@robmoffat

Copy link
Copy Markdown
Member Author

Ready for review

"@cucumber/pretty-formatter": "1.0.1",
"@finos/testing": "3.0.0-alpha.2",
"@finos/fdc3-schema": "3.0.0-alpha.2",
"@robmoffat/standard-cucumber-steps": "1.1.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this dependency a temporary measure or intended long term?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to move SCS to being a repo within the FDC3 project - but Kris asked for a PR (this one) demonstrating it worked first.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So eventually, @finos/standard-cucumber-steps

@codecov-commenter

codecov-commenter commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (cb00631) to head (8a8a70e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1890   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          73       73           
  Lines        4251     4251           
  Branches      596      674   +78     
=======================================
  Hits         4040     4040           
  Misses        211      211           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kriswest

Copy link
Copy Markdown
Contributor

@robmoffat I know you are waiting to be able to migrate the testing repo. This PR will also need rebasing against main to thin down the diff. You also have a static code analysis issue to fix

Replace @finos/testing with the external @finos/cucumber-testing-steps
package and move FDC3-specific schema matchers into fdc3-schema.
@robmoffat
robmoffat force-pushed the cucumber-testing-steps-port branch from 49111c6 to 9b97e55 Compare September 1, 2026 11:00
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 1, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: robmoffat / name: Rob Moffat (9b97e55)

@robmoffat
robmoffat changed the base branch from security-documentation-rebase to main September 1, 2026 11:04
@robmoffat

Copy link
Copy Markdown
Member Author

/easycla

@robmoffat
robmoffat marked this pull request as draft September 1, 2026 12:49
@robmoffat
robmoffat marked this pull request as ready for review September 1, 2026 12:49
@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 8a8a70e
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/6a970ba3b519620008b465c6
😎 Deploy Preview https://deploy-preview-1890.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants