Cucumber testing steps port - #1890
Conversation
|
Ready for review |
| "@cucumber/pretty-formatter": "1.0.1", | ||
| "@finos/testing": "3.0.0-alpha.2", | ||
| "@finos/fdc3-schema": "3.0.0-alpha.2", | ||
| "@robmoffat/standard-cucumber-steps": "1.1.0", |
There was a problem hiding this comment.
is this dependency a temporary measure or intended long term?
There was a problem hiding this comment.
I want to move SCS to being a repo within the FDC3 project - but Kris asked for a PR (this one) demonstrating it worked first.
There was a problem hiding this comment.
So eventually, @finos/standard-cucumber-steps
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 73 73
Lines 4251 4251
Branches 596 674 +78
=======================================
Hits 4040 4040
Misses 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@robmoffat I know you are waiting to be able to migrate the testing repo. This PR will also need rebasing against main to thin down the diff. You also have a static code analysis issue to fix |
Replace @finos/testing with the external @finos/cucumber-testing-steps package and move FDC3-specific schema matchers into fdc3-schema.
49111c6 to
9b97e55
Compare
|
|
|
/easycla |
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Describe your change
This pull request updates the test infrastructure and standardized test step definitions. The main updates include switching from a custom/shared testing package to using Standard Cucumber Steps (to move into FINOS), updating test scenarios to use the new step syntax, and making minor improvements to developer tooling.
Test infrastructure and step definitions:
@finos/testingpackage with standardized Cucumber steps from@robmoffat/standard-cucumber-stepsand FDC3-specific steps from@finos/fdc3-schema/cucumber. This change is reflected in bothpackage.jsonand documentation, and updates the source of generic test steps and utilities. [1] [2] [3] [4].featuretest files inpackages/fdc3-agent-proxy/test/features/to use the new step syntax, replacing phrases likewith parameter(s)orwith parameterswithusing argument(s)orusing arguments, to match the new standardized step definitions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Developer tooling:
viewscript topackages/fdc3-agent-proxy/package.jsonfor previewing test result HTML output with Vite.These changes modernize the test setup, ensure better maintainability by using widely adopted Cucumber steps, and improve documentation and developer experience.
Related Issue
#1889
Contributor License Agreement
Review Checklist