Add optional FDC3 version property to AppD record - #1965
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
julianna-ciq
changed the title
|
picked up some conflicts and is failing out of the website build for some reason - needs investigation |
|
@kriswest I think Netlify is failing because |
|
Hmm, dependabot is supposed to have the same setting: Line 13 in 31f79d4 and it proposed that update. I guess its not applying that config to the website folder?? Would also explain why its not grouping updates for the website. I'll raise something to try and do that downgrade and fix the dependabot config. |
|
@julianna-ciq This should fix it, could you take a look: #2007 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 95.11% 95.15% +0.04%
==========================================
Files 73 73
Lines 4196 4212 +16
Branches 667 675 +8
==========================================
+ Hits 3991 4008 +17
+ Misses 205 204 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Is this still a draft? can you change title if not and I'll review |
julianna-ciq
changed the title
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
The regex for validation needs testing and needs a few tweaks - we should lose the v1 appD spec at the same time
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { Directory, DirectoryApp, DirectoryIntent } from './DirectoryInterface.js'; | ||
|
|
||
| // Keep synchronized with BaseApplication.properties.fdc3Version.pattern in appd.schema.json. | ||
| export const FDC3_VERSION_RANGE_PATTERN = |
There was a problem hiding this comment.
is this the best way of doing this? Can't we use the semver library to verify the versions?
If we do want to keep this it's probably a good idea to have some comments here explaining with examples of what are valid versions.
| } | ||
| } | ||
|
|
||
| export function appSupportsFdc3Version(app: DirectoryApp, fdc3Version: string): boolean { |
There was a problem hiding this comment.
I assume fdc3Version here is the version of the desktop agent and not a range?
5 participants
Summary
fdc3Versionmetadata as an npm-style semver rangeFixes #1871
Verification
npx.cmd tsc -p toolbox/fdc3-for-web/fdc3-web-impl/tsconfig.json --noEmitnpm.cmd test --workspace toolbox/fdc3-for-web/fdc3-web-impl -- BasicDirectoryreaches compile, then stops becausevitestis not installed in the local checkout