Add basic addEventListener conformance tests - #2154
Open
julianna-ciq wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2154 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 73 73
Lines 4251 4251
Branches 671 593 -78
=======================================
Hits 4040 4040
Misses 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds basic conformance coverage for
DesktopAgent.addEventListener:BasicAEL1verifies the method exists, is callable foruserChannelChanged, and returns aListenerwith anunsubscribefunction.BasicAEL2verifies the unfilterednullevent type also returns a validListener.Basic-Tests.mdand adds the required changelog entry.This builds on the approach in #1817 and incorporates the outstanding review feedback there: current
main, synchronized conformance documentation, a changelog entry, and explicit test descriptions.Related Issue
Resolves #1774
Contributor License Agreement
Review Checklist
Verification
npm run build --workspace toolbox/fdc3-conformancegit diff --check