Skip to content

Add basic addEventListener conformance tests - #2154

Open
julianna-ciq wants to merge 1 commit into
mainfrom
fix/1774-add-event-listener-conformance
Open

Add basic addEventListener conformance tests#2154
julianna-ciq wants to merge 1 commit into
mainfrom
fix/1774-add-event-listener-conformance

Conversation

@julianna-ciq

Copy link
Copy Markdown
Contributor

Describe your change

Adds basic conformance coverage for DesktopAgent.addEventListener:

  • BasicAEL1 verifies the method exists, is callable for userChannelChanged, and returns a Listener with an unsubscribe function.
  • BasicAEL2 verifies the unfiltered null event type also returns a valid Listener.
  • Registers both tests in the basic suite and adds the API documentation link.
  • Documents both test definitions in Basic-Tests.md and adds the required changelog entry.

This builds on the approach in #1817 and incorporates the outstanding review feedback there: current main, synchronized conformance documentation, a changelog entry, and explicit test descriptions.

Related Issue

Resolves #1774

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?
  • API changes: No API changes; this PR adds conformance coverage and synchronized documentation only.

Verification

  • npm run build --workspace toolbox/fdc3-conformance
  • Prettier check for all changed files
  • git diff --check

@julianna-ciq
julianna-ciq requested a review from a team as a code owner August 27, 2026 15:14
@netlify

netlify Bot commented Aug 27, 2026

Copy link
Copy Markdown

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 0baf283
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/6a90544764973f0008cdaff7
😎 Deploy Preview https://deploy-preview-2154.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (9ff3585) to head (0baf283).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2154   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          73       73           
  Lines        4251     4251           
  Branches      671      593   -78     
=======================================
  Hits         4040     4040           
  Misses        211      211           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Roaders Roaders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Basic conformance test for addEventListener

3 participants