Skip to content

Display Controls on Node Details #1293

Closed
oliviajanejohns wants to merge 13 commits intofinos:mainfrom
oliviajanejohns:hackday
Closed

Display Controls on Node Details #1293
oliviajanejohns wants to merge 13 commits intofinos:mainfrom
oliviajanejohns:hackday

Conversation

@oliviajanejohns
Copy link
Contributor

@oliviajanejohns oliviajanejohns commented May 16, 2025

  • Display Controls for a node in the node detail view
Screenshot 2025-05-18 at 16 27 54 Screenshot 2025-05-18 at 23 01 43
  • Removed these dependencies as they are unused and was seeing errors in our console previously
  • Added 'watch-test' command

@oliviajanejohns oliviajanejohns changed the title Remove unused cytoscape dependencies Display Controls on Node Details May 18, 2025
@aidanm3341
Copy link
Member

my only potential gripe with how this is done is how custom it is, and means we are very coupled to the existing structure of all of the different CALM objects. If we were to add a new field to anything in CALM, we'd need a change here to support it.

Just for the sake of trying it to compare, can we see what the SideBar looks like using the existing JsonRenderer component that's currently only used in the hub? The downside of that approach is that it's slightly less user-friendly in the sense that it includes all the json brackets and other syntax, but the upside is that it's perfectly flexible and will display everything that isn't rendered in the graph even when we add new stuff in the future, with no changes required. It also means a lot less code to maintain.

@oliviajanejohns
Copy link
Contributor Author

Following @aidanm3341's feedback. Have tried using the JSON Renderer, let me know your thoughts before I improve styling (and remove the Visualize) button

Screenshot 2025-05-30 at 15 22 35

@aidanm3341
Copy link
Member

yeah, this looks good to me. I personally like the simplicity of this approach @oliviajanejohns, and it's still human readable enough to be worth it IMO. I'm not certain from your screenshot, but are you just using this for controls specifically here? Can we just use this approach to render the entire node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants