Skip to content

fix(shared): update validate() signature to accept undefined #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markscott-ms merged 3 commits into from
Feb 28, 2026
Merged

fix(shared): update validate() signature to accept undefined #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86a19c4
fix(shared): update validate() signature to accept undefined architec…
rocketstack-matt Feb 28, 2026
a469e5b
Merge branch 'main' into fix/validate-signature-accepts-undefined
rocketstack-matt Feb 28, 2026
126bcb5
fix(shared): address copilot review feedback
rocketstack-matt Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/src/command-helpers/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ export async function runValidate(options: ValidateOptions) {
const schemaDirectory = await buildSchemaDirectory(docLoader, options.verbose);
await schemaDirectory.loadSchemas();

let architecture: object | undefined;
let pattern: object | undefined;
let timeline: object | undefined;
let architecture: object | undefined = undefined;
let pattern: object | undefined = undefined;
let timeline: object | undefined = undefined;

if (options.timelinePath) {
const result = await loadTimeline(
Expand Down
6 changes: 3 additions & 3 deletions shared/src/commands/validate/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ async function runSpectralValidations(

/**
* Validation - with simple input parameters and output validation outcomes.
* @param architecture The architecture as a JS object
* @param patternOrSchema The pattern (or schema) as a JS object
* @param timeline The timeline as a JS object
* @param architecture The architecture as a JS object, or undefined if not provided
* @param patternOrSchema The pattern (or schema) as a JS object, or undefined if not provided
* @param timeline The timeline as a JS object, or undefined if not provided
* @param schemaDirectory SchemaDirectory instance for schema resolution
* @param debug Whether to log at debug level
* @returns Validation report
Expand Down
Loading