Skip to content

feat(cli): remove server functionality (now in @finos/calm-server package)#2195

Merged
rocketstack-matt merged 3 commits intofinos:mainfrom
markscott-ms:issues/2051-delete-cli-server
Mar 2, 2026
Merged

feat(cli): remove server functionality (now in @finos/calm-server package)#2195
rocketstack-matt merged 3 commits intofinos:mainfrom
markscott-ms:issues/2051-delete-cli-server

Conversation

@markscott-ms
Copy link
Contributor

@markscott-ms markscott-ms commented Feb 28, 2026

Description

To be merged only after #2194 and #2199 , and @finos/calm-server package has been successfully published.

This pull request removes the experimental HTTP server ("server" command) functionality from the CALM CLI, along with all related code, tests, documentation, and dependencies. The CLI and documentation are now focused solely on the core commands (generate, validate, template, docify, init-ai).

The validation server had been documented in the CALM website "Working with CALM" section.

Whilst this is a BREAKING CHANGE, it is removal of an Experimental feature and does not merit a major CLI release version change.

Functionality has been moved to a separate @finos/calm-server package.

Key changes include:

CLI Command and Documentation

  • Removed all references to the server command from CLI documentation files (cli/README.md, calm-ai/tools/calm-cli-instructions.md, cli/AGENTS.md), including usage instructions, options, and examples. [1] [2] [3] [4] [5]
  • Updated the CLI source (cli/src/cli.ts) to remove the server command and its options. [1] [2]
  • The validation server had been documented in the CALM website "Working with CALM" section.

Codebase Simplification

  • Deleted the entire server implementation and all related route handlers and helper files (cli/src/server/cli-server.ts, cli/src/server/routes/routes.ts, cli/src/server/routes/health-route.ts). [1] [2] [3]
  • Removed server-related directories from code structure documentation (cli/AGENTS.md).

Test Suite Cleanup

  • Removed all tests related to the server command and HTTP routes, including integration and unit tests for server startup, health checks, and validation endpoints (cli/src/cli.e2e.spec.ts, cli/src/cli.spec.ts, cli/src/server/cli-server.integration.spec.ts, cli/src/server/routes/health-route.spec.ts, cli/src/server/routes/routes.spec.ts). [1] [2] [3] [4] [5] [6] [7]

Dependency Removal

  • Removed server-related dependencies (express-rate-limit, supertest, @types/supertest) from cli/package.json. [1] [2]

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Code style/formatting changes
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvements
  • ✅ Test additions or updates
  • 🔧 Chore (maintenance, dependencies, CI, etc.)

Affected Components

  • CLI (cli/)
  • Schema (calm/)
  • CALM AI (calm-ai/)
  • CALM Hub (calm-hub/)
  • CALM Hub UI (calm-hub-ui/)
  • CALM Server (calm-server/)
  • CALM Widgets (calm-widgets/)
  • Documentation (docs/)
  • Shared (shared/)
  • VS Code Extension (calm-plugins/vscode/)
  • Dependencies
  • CI/CD

Commit Message Format ✅

Testing

  • I have tested my changes locally
  • I have added/updated unit tests
  • All existing tests pass

Checklist

  • My commits follow the conventional commit format
  • I have updated documentation if necessary
  • I have added tests for my changes (if applicable)
  • My changes follow the project's coding standards

@markscott-ms markscott-ms force-pushed the issues/2051-delete-cli-server branch from bb187d0 to f2d4e05 Compare February 28, 2026 21:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the experimental HTTP server capability from the @finos/calm-cli workspace now that the functionality has moved to the standalone @finos/calm-server package, simplifying the CLI surface area and related maintenance.

Changes:

  • Removed the server command from the CLI entrypoint and deleted all CLI server implementation code under cli/src/server/.
  • Removed server-related tests (unit, route, and e2e) and cleaned up server-specific dependencies.
  • Updated CLI documentation/help excerpts to no longer mention the server command.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package-lock.json Removes server-related packages from the CLI workspace; also includes additional lockfile metadata churn.
docs/docs/working-with-calm/using-the-cli.md Removes server from the documented CLI command list.
cli/src/server/routes/validation-route.ts Deletes validation HTTP route implementation (moved out of CLI).
cli/src/server/routes/validation-route.spec.ts Deletes route tests that depended on supertest.
cli/src/server/routes/routes.ts Deletes server route wiring.
cli/src/server/routes/routes.spec.ts Deletes server route wiring unit tests.
cli/src/server/routes/health-route.ts Deletes /health route implementation.
cli/src/server/routes/health-route.spec.ts Deletes /health route tests.
cli/src/server/cli-server.ts Deletes express server startup helper.
cli/src/server/cli-server.integration.spec.ts Deletes server startup integration test.
cli/src/cli.ts Removes the server command registration/options from the CLI.
cli/src/cli.spec.ts Removes unit test coverage for the CLI server command wiring.
cli/src/cli.e2e.spec.ts Removes e2e coverage for calm server behavior.
cli/package.json Removes server-related dependencies (express-rate-limit, supertest, @types/supertest).
cli/README.md Removes server from the CLI help text and deletes the server documentation section.
cli/AGENTS.md Removes server from the “Key Commands” / directory overview docs for AI assistants.
calm-ai/tools/calm-cli-instructions.md Removes references to server from CLI instructions used by AI tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rocketstack-matt rocketstack-matt merged commit 1ce8615 into finos:main Mar 2, 2026
14 checks passed
@markscott-ms markscott-ms deleted the issues/2051-delete-cli-server branch March 2, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants