Update Load Balancer Threats#718
Conversation
|
|
✅ Deploy Preview for common-cloud-controls canceled.
|
I've also had a stab at a controls set. I'm unsure about some of the testing requirements as some of them feel excessive compare to many of the other testing requirements we've seen so far and am also just guessing on some of the parameters for those tests that might make sense... Would really like us to be able to hand this over to @damienjburks in next few days... |
mlysaght2017
left a comment
There was a problem hiding this comment.
Needs refactoring to align with new format and to also add common (shared) threats.
@mlysaght2017 Thanks for your help. |
|
@zigmax - as mentioned, the controls are just a stab - I think they align ok with the threats, just really not sure if thats how detailed we want to go on the testing requirements, particularly if some of these controls are well managed and well documented by the CSPs... |
Removed CCC.LB.C03 | Protect Configuration Changes
Refactoring the content.
|
@mlysaght2017 Thanks for the feedback. I can cancel the pull request, and we can proceed with the controls and threats that Paul created. #713 |
|
@zigmax - I've reviewed the threats and controls again and am happy with how they exist on this PR. Paul Bayer is having issues with CLA so I would like us to run with your PR to keep momentum. |
|
@eddie-knight @damienjburks - can you please review/approve |
Fix linting issues.
|
@zigmax - added some suggestions and removed some of the style deviations. I think once you get through that last batch, I'm good. |
Update threat title. Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
|
@eddie-knight @damienjburks - can you please review again - I think we've gotten this to a good state now. If you approve, we can move it over to Damien for RC |
b98a3aa
First commit of threats for Load Balancer.