Skip to content

Update Load Balancer Threats#718

Merged
damienjburks merged 32 commits intofinos:mainfrom
zigmax:patch-1
May 29, 2025
Merged

Update Load Balancer Threats#718
damienjburks merged 32 commits intofinos:mainfrom
zigmax:patch-1

Conversation

@zigmax
Copy link
Copy Markdown
Contributor

@zigmax zigmax commented Apr 17, 2025

First commit of threats for Load Balancer.

@zigmax zigmax requested a review from a team as a code owner April 17, 2025 00:33
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2025

Deploy Preview for common-cloud-controls canceled.

Name Link
🔨 Latest commit b98a3aa
🔍 Latest deploy log https://app.netlify.com/projects/common-cloud-controls/deploys/683742bce9f93000084994d6

@mlysaght2017
Copy link
Copy Markdown
Contributor

@zigmax @eddie-knight

  • I had a stab at refactoring the threats to align with the new format and to also add in common (shared) threats and remove duplications from the service specific threats

I've also had a stab at a controls set. I'm unsure about some of the testing requirements as some of them feel excessive compare to many of the other testing requirements we've seen so far and am also just guessing on some of the parameters for those tests that might make sense...

Would really like us to be able to hand this over to @damienjburks in next few days...

Copy link
Copy Markdown
Contributor

@mlysaght2017 mlysaght2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs refactoring to align with new format and to also add common (shared) threats.

@zigmax
Copy link
Copy Markdown
Contributor Author

zigmax commented May 1, 2025

Needs refactoring to align with new format and to also add common (shared) threats.

@mlysaght2017 Thanks for your help.

@mlysaght2017
Copy link
Copy Markdown
Contributor

@zigmax - as mentioned, the controls are just a stab - I think they align ok with the threats, just really not sure if thats how detailed we want to go on the testing requirements, particularly if some of these controls are well managed and well documented by the CSPs...

Removed CCC.LB.C03 | Protect Configuration Changes
@eddie-knight eddie-knight self-requested a review May 2, 2025 12:41
Refactoring the content.
@zigmax
Copy link
Copy Markdown
Contributor Author

zigmax commented May 12, 2025

@mlysaght2017 Thanks for the feedback. I can cancel the pull request, and we can proceed with the controls and threats that Paul created. #713

@mlysaght2017 mlysaght2017 requested a review from a team May 15, 2025 11:09
@mlysaght2017
Copy link
Copy Markdown
Contributor

@zigmax - I've reviewed the threats and controls again and am happy with how they exist on this PR. Paul Bayer is having issues with CLA so I would like us to run with your PR to keep momentum.

@mlysaght2017 mlysaght2017 requested a review from a team May 15, 2025 11:12
@mlysaght2017
Copy link
Copy Markdown
Contributor

@eddie-knight @damienjburks - can you please review/approve

@mlysaght2017 mlysaght2017 requested a review from a team May 15, 2025 11:39
mlysaght2017
mlysaght2017 previously approved these changes May 15, 2025
Fix linting issues.
damienjburks
damienjburks previously approved these changes May 15, 2025
@mlysaght2017
Copy link
Copy Markdown
Contributor

@zigmax - added some suggestions and removed some of the style deviations. I think once you get through that last batch, I'm good.

zigmax and others added 13 commits May 22, 2025 11:19
Update threat title.

Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
Co-authored-by: Michael Lysaght <31510876+mlysaght2017@users.noreply.github.com>
mlysaght2017
mlysaght2017 previously approved these changes May 23, 2025
@mlysaght2017
Copy link
Copy Markdown
Contributor

@eddie-knight @damienjburks - can you please review again - I think we've gotten this to a good state now.

If you approve, we can move it over to Damien for RC

damienjburks
damienjburks previously approved these changes May 23, 2025
Copy link
Copy Markdown
Contributor

@damienjburks damienjburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved

eddie-knight
eddie-knight previously approved these changes May 28, 2025
@eddie-knight eddie-knight dismissed stale reviews from damienjburks, mlysaght2017, and themself via b98a3aa May 28, 2025 17:07
@damienjburks damienjburks merged commit 4417007 into finos:main May 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants