Skip to content

Website improvements#745

Merged
robmoffat merged 7 commits intofinos:cfi-testsfrom
gaganahluwalia:cfi-tests
May 22, 2025
Merged

Website improvements#745
robmoffat merged 7 commits intofinos:cfi-testsfrom
gaganahluwalia:cfi-tests

Conversation

@jmatthews-scottlogic
Copy link
Copy Markdown
Contributor

Hi Rob,

We've tackled the items in your Website Improvements list, except for Left-hand navigator (figure out how to turn this on). The left-hand nav is only supported for markdown-based docs, rather than the dynamically created pages in use here.

Hope these changes are helpful.

Joel and Gagan

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented May 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@jmatthews-scottlogic
Copy link
Copy Markdown
Contributor Author

Working on correcting the git authors now

@robmoffat robmoffat changed the base branch from cfi-tests to main May 14, 2025 20:31
@robmoffat
Copy link
Copy Markdown
Member

trying to get the preview working

@robmoffat robmoffat changed the base branch from main to cfi-tests May 14, 2025 20:31
@robmoffat
Copy link
Copy Markdown
Member

Ok, good start!

Can we make this look a little more like a breadcrumb? And omit it from the project front page?

Screenshot 2025-05-14 at 16 35 09
  • Perhaps create ovals around the parts
  • Make Title Case
  • ccc -> Common Cloud Controls

@@ -0,0 +1,298 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on with this file?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelt wrong if needed too

@jmatthews-scottlogic
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback Rob, we're working through it now.

I can remove the controlMappins.json file and dynamically create the required links to the sources.

NIST host control information themselves, and I've found a good source for CCM. ISO have their control information behind a paywall however and the only pages I've found are third party blogs that aren't authoritative. What do you suggest for the ISO links?

@robmoffat
Copy link
Copy Markdown
Member

robmoffat commented May 16, 2025

Adding @eddie-knight as he maintains the schema project and might have thought about this.

Ideally, we need to have a URL for each of these reference-ids, perhaps a file that dereferences them and explains what they are all for?

Something like

# references.yaml

sources: 
  - id: NIST_800_53
    source_url: https://csrc.nist.gov/pubs/sp/800/53/r5/upd1/final
    version: v5
    title: "Security and Privacy Controls for Information Systems and Organizations"
    reference_pattern: "https://csf.tools/reference/nist-sp-800-53/r5/${id.substring(0,2)}/${id}/"

Am I on the right track here?

@robmoffat
Copy link
Copy Markdown
Member

I've approved the PR. You can merge when you're ready.

@eddie-knight
Copy link
Copy Markdown
Collaborator

@robmoffat that looks pretty close to the structure in the new metadata schema.

example: https://github.com/ossf/security-baseline/blob/main/baseline/frameworks.yaml

@jmatthews-scottlogic
Copy link
Copy Markdown
Contributor Author

Would someone merge this if you're happy please?

@robmoffat robmoffat merged commit 44f7a1a into finos:cfi-tests May 22, 2025
8 of 13 checks passed
@robmoffat
Copy link
Copy Markdown
Member

@robmoffat that looks pretty close to the structure in the new metadata schema.

example: https://github.com/ossf/security-baseline/blob/main/baseline/frameworks.yaml

I take it we don't have one of these in CCC yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants