AddEventListener support for IDesktopAgent and IPrivateChannel#170
AddEventListener support for IDesktopAgent and IPrivateChannel#170bingenito merged 5 commits intofinos:mainfrom
Conversation
|
I will add tests for the concrete event classes to ensure constructor initialization is done correctly |
kriswest
left a comment
There was a problem hiding this comment.
LGTM - but needs the UserChannelChanged event to fire on leaving the channel as well as switching channel
7ce95e4 to
2675229
Compare
|
@bingenito Thanks for working on this! So just to clarify, are you proposing to just stick with the Fdc3Event and not create the type of the IApiEvent? I see how it does not add much value, especially if you use your definitions of IFdc3Event and Fdc3Event so I am fine with modifying it that way |
|
@kemerava I am with @bingenito on this - C# (and I think Java too) do not have the expressiveness to have the same notion as is expressed in the TS definition when comes to the typedness of these |
kriswest
left a comment
There was a problem hiding this comment.
One unimplemented function (removing listeners), a question and a minor typo.
Co-authored-by: Kris West <kris.west@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 75.93% 77.95% +2.02%
==========================================
Files 55 63 +8
Lines 453 549 +96
Branches 49 49
==========================================
+ Hits 344 428 +84
- Misses 87 98 +11
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. |
…m package for consistency in expectations for developers using both implementations.
…dotnet into AddEventListener
|
Associated FDC3 docs PR: |
Implementation of core event system of FDC3 2.2
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.