Update React and related dependencies to version 17.0.2#59
Open
gliptak wants to merge 1 commit intofinos:developfrom
Open
Update React and related dependencies to version 17.0.2#59gliptak wants to merge 1 commit intofinos:developfrom
gliptak wants to merge 1 commit intofinos:developfrom
Conversation
7bebdc3 to
7b86b29
Compare
Contributor
|
We should hold off on this React 17 upgrade for the moment. We are actively pursuing migrating the ~1700 tests from Karma to Jest, and from Enzyme to React Testing Library using a combination of codemods and GenAI tooling. The component tests would be of particular concern here, as we are using Enzyme to fully render the DOM tree as part of our migrator tool, and there is only unofficial support for React 17 via https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17. Once the tests are migrated we will be in a position to migrate to React 18 and beyond. |
Contributor
|
Here are some resources we have used to help inform our approach to the migration: |
Contributor
Author
|
thank you @bryankenneally I'm trying to see if an (v17) upgrade is possible with minimum changes |
95d478b to
923d126
Compare
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update React and related dependencies to version 17.0.2 and adjust Babel preset configuration
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}