Update template discovery to make its order deterministic#289
Merged
Conversation
Template files are discovered on the system using os.walk, which does not guarantee deterministic order. This commit makes their order consistent by sorting them by path in lexicographic order.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 64.28% 64.28%
=======================================
Files 6 6
Lines 98 98
Branches 14 11 -3
=======================================
Hits 63 63
Misses 32 32
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
de-minimis change for dco purposes, thanks for the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template files are discovered on the system using os.walk, which does not guarantee deterministic order. This can result in a messy user experience, where templates with the same prefix name in a directory will not appear together in the UI.
This PR makes the order consistent by sorting templates by path in lexicographic order.