feature: added flag which will add DEFECT_COUNT column to dq execute api#4517
Open
dramala wants to merge 1 commit intofinos:masterfrom
Open
feature: added flag which will add DEFECT_COUNT column to dq execute api#4517dramala wants to merge 1 commit intofinos:masterfrom
dramala wants to merge 1 commit intofinos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
What does this PR do / why is it needed ?
Added flag which will add DEFECT_COUNT column to dq execute api. Default of flag is false.
Also fixed previous issue of defectLimit not working when multiple validations executed.
Clarifications
The flag defectLimit is now applied on a per-validation basis rather than a global basis. This resolves previous issues where the limit did not function correctly when multiple validations were processed in a single request.
previous behavior: The defectLimit was inconsistent or failed to apply correctly across multiple validations.
current behavior If a user sets a defectLimit of n and execute r validations, the maximum potential rows returned is n * r. Example, if defectLimit = 10 and users executes 2 validations, the API will return up to 20 rows (10 for each), assuming enough defects are identified.
If the includeTotalDefectCount flag is present with multiple validations then, the added column will be validation specific meaning you will get results such as