Skip to content

feature: added flag which will add DEFECT_COUNT column to dq execute api#4517

Open
dramala wants to merge 1 commit intofinos:masterfrom
goldmansachs:review-defect-count-flag
Open

feature: added flag which will add DEFECT_COUNT column to dq execute api#4517
dramala wants to merge 1 commit intofinos:masterfrom
goldmansachs:review-defect-count-flag

Conversation

@dramala
Copy link
Contributor

@dramala dramala commented Mar 6, 2026

What type of PR is this?

improvement

What does this PR do / why is it needed ?

Added flag which will add DEFECT_COUNT column to dq execute api. Default of flag is false.

Also fixed previous issue of defectLimit not working when multiple validations executed.

Clarifications

  1. The flag defectLimit is now applied on a per-validation basis rather than a global basis. This resolves previous issues where the limit did not function correctly when multiple validations were processed in a single request.
    previous behavior: The defectLimit was inconsistent or failed to apply correctly across multiple validations.
    current behavior If a user sets a defectLimit of n and execute r validations, the maximum potential rows returned is n * r. Example, if defectLimit = 10 and users executes 2 validations, the API will return up to 20 rows (10 for each), assuming enough defects are identified.

  2. If the includeTotalDefectCount flag is present with multiple validations then, the added column will be validation specific meaning you will get results such as

Name DEFECT_COUNT
Validation A 100
Validation A 100
Validation B 150
Validation B 150

@dramala dramala requested a review from a team as a code owner March 6, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant