Skip to content

Shared CodeDependencyResolutionState through Java Generation - #5000

Merged
aziemchawdhary-gs merged 1 commit into
finos:masterfrom
goldmansachs:review-m2m-graphfetch-javagen-optimization
Jul 30, 2026
Merged

Shared CodeDependencyResolutionState through Java Generation#5000
aziemchawdhary-gs merged 1 commit into
finos:masterfrom
goldmansachs:review-m2m-graphfetch-javagen-optimization

Conversation

@fsegatz

@fsegatz fsegatz commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Improvement

What does this PR do / why is it needed ?

Thread a single CodeDependencyResolutionState through the whole generation. It's seeded once at the bindPlan root and carried through the execution-node recursion (child nodes, GlobalGraphFetch/FreeMarker branches) and the m2m/graphFetch handler chain, so once a function is generated it's cached and reused everywhere else instead of being regenerated.

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@fsegatz
fsegatz requested a review from a team as a code owner July 30, 2026 13:22
@github-actions

Copy link
Copy Markdown

Test Results

  1 058 files   -        6    1 058 suites   - 6   3h 14m 49s ⏱️ - 1h 4m 39s
19 701 tests  -    107  19 522 ✔️  -    107  179 💤 ±0  0 ±0 
41 017 runs   - 2 990  40 838 ✔️  - 2 990  179 💤 ±0  0 ±0 

Results for commit 5a5d358. ± Comparison against base commit ab7a53c.

@aziemchawdhary-gs
aziemchawdhary-gs merged commit ebc7e02 into finos:master Jul 30, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants