Skip to content

Make ClassProcessor.isPlatformClass respect the current class loader#1213

Merged
MauricioUyaguari merged 1 commit intofinos:masterfrom
kevin-m-knight-gs:minor_fixes
Mar 10, 2026
Merged

Make ClassProcessor.isPlatformClass respect the current class loader#1213
MauricioUyaguari merged 1 commit intofinos:masterfrom
kevin-m-knight-gs:minor_fixes

Conversation

@kevin-m-knight-gs
Copy link
Contributor

Make ClassProcessor.isPlatformClass respect the current class loader.

Previously, the set of platform classes was cached statically based on the context class loader of the first thread to call the method. Which means that it might not reflect the state based on the context class loader of the calling thread.

Now it is cached in a weak reference map keyed by the context class loader of the calling thread. So it always reflects the state of the context class loader of the calling thread.

@kevin-m-knight-gs kevin-m-knight-gs requested a review from a team as a code owner March 10, 2026 19:25
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Test Results

   592 files  ±0     592 suites  ±0   1h 32m 32s ⏱️ - 1m 17s
4 798 tests ±0  4 758 ✔️ ±0  40 💤 ±0  0 ±0 
5 671 runs  ±0  5 631 ✔️ ±0  40 💤 ±0  0 ±0 

Results for commit de8976e. ± Comparison against base commit 2ed7e15.

♻️ This comment has been updated with latest results.

@MauricioUyaguari MauricioUyaguari merged commit f3c8d7a into finos:master Mar 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants