Branch for YMQ integration to Scaler#430
Merged
sharpener6 merged 36 commits intofinos:mainfrom Jan 6, 2026
Merged
Conversation
79bf3e2 to
0332c19
Compare
rafa-be
reviewed
Nov 17, 2025
sharpener6
reviewed
Nov 17, 2025
sharpener6
reviewed
Nov 18, 2025
5d48fc1 to
d998bda
Compare
Signed-off-by: gxu <georgexu420@163.com>
- It should cleanup by removing the connection and talk back to user - Also, add a safety net for removeIOSocket Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Co-authored-by: rafa-be <raphael@noisycamp.com>
Co-authored-by: rafa-be <raphael@noisycamp.com>
Co-authored-by: rafa-be <raphael@noisycamp.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
This reverts commit d2f03ef.
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
e09b168 to
60d18cc
Compare
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
rafa-be
reviewed
Jan 5, 2026
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
Signed-off-by: gxu <georgexu420@163.com>
sharpener6
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW.
The test cases when using
tcp_zmqasSCALER_NETWORK_BACKENDis passing, after fixing a bug in OSS.There are still two test cases that are not passed whenSCALER_NETWORK_BACKENDisymq. They likely are caused by the same underlying bug that I couldn't find.There is a bug in the worker side. The worker, when shutdown requested through signal handle, is sending a
DisconnectRequest. It should wait forDisconnectResponseafterwards. This was never done. The old version of the code exits immediately after sendingDisconnectRequest.This results to hang in the Scheduler side. The Scheduler, upon receiving
DisconnectRequestfrom downstream, tries to sendDisconnectResponseback. The Scheduler equipped withymqconnectors will stuck on statement:and no other
recv/sendoperation can be completed due to the interface's implementation. Apparently, we don't have this problem whenzmqconnectors equipped. This is because their implementation contains internal polling in the interface side. We don't have it.But the culprit is the worker not waiting on
DisconnectResponse. Hence, this really is a bug inscaleritself, but was hidden byzmqconnectors.