Remove WorkerGroup abstraction from scheduler#594
Draft
gxuu wants to merge 1 commit intofinos:mainfrom
Draft
Conversation
Replace WorkerGroupID with direct WorkerID tracking throughout the scheduler. Workers now carry worker_manager_id in heartbeats. The scheduler sees individual workers; only the ECS adapter maintains an internal translation layer (worker groups → ECS task ARNs). Key changes: - Protocol: WorkerManagerHeartbeat uses max_workers instead of max_worker_groups/workers_per_group. Commands renamed to StartWorkers/ShutdownWorkers with worker_ids list. - Scaling policies: operate on managed_worker_ids (List[WorkerID]) and managed_worker_capabilities (Dict[str, int]) instead of WorkerGroupState/WorkerGroupCapabilities. - WorkerManagerController: tracks workers per manager source via _manager_worker_ids (Dict[bytes, Set[WorkerID]]). - WorkerController: tracks worker→manager mapping from heartbeats. - Adapters: native/symphony flattened to Dict[WorkerID, Worker]. ECS keeps internal group→task_arn mapping invisible to scheduler. - Removed: WorkerGroupID, WorkerGroupInfo, WorkerGroupState, WorkerGroupCapabilities types. Signed-off-by: gxu <georgexu420@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW. THIS IS A WORK IN PROGRESS.
Replace WorkerGroupID with direct WorkerID tracking throughout the scheduler. Workers now carry worker_manager_id in heartbeats. The scheduler sees individual workers; only the ECS adapter maintains an internal translation layer.
Key changes: