Conversation
texodus
force-pushed
the
render-lag-fix
branch
from
d3b90b5 to
ad06ae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which regressed the behavior of
draw()to sometimes return early (under heavy conflation). The regression occurred due to a (correct) replacement of a customPromise-closure-capture Rube Goldberg contraption withPromise.withResolvers, but did not update all access of this change to use thepromisefield of the returned struct (and was not caught by TypeScript, because it inherits the behavior from JavaScript to no-opawaita non-awaitable).This PR also adds a test which chaos-scrolls and resets to asset that scroll-initiated renders draw the final scroll position consistently. Additionally, a small randomized timeout has been added to other test models to make sure the results are not dependent on timing issues.