Merged
Conversation
…lt. In the scenario where we place multiple FilterClauses (without a filtereditor) on the page, they render with open dropdowns. This dropdown behaviour can now be controlled via a prop. Also, for multiselect setup, if the valies are cleared, the model will trigger a commit on close of the dropdown. (useFilterClause.ts -> handleOpenChange). This will enable the consumer to attach a handler based on the value of the filter.
…will help (along with the filterTouched ref) in identifying if the dropdown needs to be shown on initial render
# Conflicts: # vuu-ui/package-lock.json
# Conflicts: # vuu-ui/package-lock.json
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
reviewed
Aug 31, 2025
Contributor
|
there is a commit history here including changes that are not related to these files. Can you keep your main branch up to date with finos and regularly rebase your feature branch onto main |
Updated the ColumnFilter examples to use state and updated minor styling for one of the example Fixed a minor issue related to state update Added some test coverage
heswell
reviewed
Sep 2, 2025
heswell
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial changes