feat: add basic wrapping to support compose #2201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
reviewed
Apr 23, 2025
app/build.gradle.kts
Outdated
| id("org.jetbrains.kotlin.plugin.compose") | ||
| id("org.jetbrains.compose") | ||
| id("com.google.gms.google-services") | ||
| id("kotlin-kapt") // ← kapt drives annotation processors |
There was a problem hiding this comment.
Suggested change
| id("kotlin-kapt") // ← kapt drives annotation processors | |
| id("kotlin-kapt") |
thatfiredev
reviewed
Apr 23, 2025
app/build.gradle.kts
Outdated
Comment on lines
17
to
20
| minSdk = Config.SdkVersions.min | ||
| targetSdk = Config.SdkVersions.target | ||
| versionName = Config.version | ||
| versionCode = 1 |
There was a problem hiding this comment.
Let's get rid of all the extra whitespaces (across all files) - I don't think it's common to use this formatting in Kotlin (at least I've never seen before)
Suggested change
| minSdk = Config.SdkVersions.min | |
| targetSdk = Config.SdkVersions.target | |
| versionName = Config.version | |
| versionCode = 1 | |
| minSdk = Config.SdkVersions.min | |
| targetSdk = Config.SdkVersions.target | |
| versionName = Config.version | |
| versionCode = 1 |
build.gradle.kts
Outdated
| @@ -19,6 +19,10 @@ buildscript { | |||
|
|
|||
| plugins { | |||
| id("com.github.ben-manes.versions") version "0.20.0" | |||
| kotlin("multiplatform") version "1.9.22" apply false | |||
There was a problem hiding this comment.
Do we need Kotlin multiplatform ? 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
./gradlew checkto ensure the Travis build passes.